Bump MSRV to 1.80 #9496
Merged
Bump MSRV to 1.80 #9496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
approved these changes
Oct 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This commit updates the minimum Rust version required to compile Wasmtime to 1.80.0 from the previous 1.78.0.
* Change MSRV window back to 2 now that oss-fuzz is resolved * Update the nightly to the latest nightly
alexcrichton
force-pushed
the
bump-msrv
branch
from
7e20441
to
8373b3f
Compare
|
The previous build issue is summarized here and we'll have to figure something out over the next ~6 weeks as that change will eventually reach stable and break us. |
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 22, 2024
This commit is a follow-up to bytecodealliance#9496 to leverage various APIs that the workspace now has access to. For example most dependencies on the `once_cell` crate are now removed in favor of the types stabilized in the standard library: `LazyLock` and `LazyCell`. One dependency remains in the `wasmtime` crate due to the `get_or_try_init` not being stable yet. Some additional helper methods on raw pointer slices are also available for removing a few minor `unsafe` blocks.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
This commit is a follow-up to #9496 to leverage various APIs that the workspace now has access to. For example most dependencies on the `once_cell` crate are now removed in favor of the types stabilized in the standard library: `LazyLock` and `LazyCell`. One dependency remains in the `wasmtime` crate due to the `get_or_try_init` not being stable yet. Some additional helper methods on raw pointer slices are also available for removing a few minor `unsafe` blocks.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 23, 2024
This commit updates nightly again in CI after failing to do so in bytecodealliance#9496. This fixes an issue in our release CI where CMake was misconfigured when cross-compiling and creating `aarch64-pc-windows-msvc` artifacts. prtest:full
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 23, 2024
This commit updates nightly again in CI after failing to do so in bytecodealliance#9496. This fixes an issue in our release CI where CMake was misconfigured when cross-compiling and creating `aarch64-pc-windows-msvc` artifacts. prtest:full
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Update nightly in CI This commit updates nightly again in CI after failing to do so in #9496. This fixes an issue in our release CI where CMake was misconfigured when cross-compiling and creating `aarch64-pc-windows-msvc` artifacts. prtest:full * Try installing ninja * Also install Ninja on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the minimum Rust version required to compile Wasmtime to 1.80.0 from the previous 1.78.0.