Use a helper method to invoke VMFuncRef::array_call
#9630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to encapsulate the usage of a native raw pointer and in the future act as a dispatch point for invoking Pulley instead of native code.
github-actions
bot
added
wasmtime:api
pchickey
approved these changes
Nov 20, 2024
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 20, 2024
This pointer is technically not safe to be a function pointer because it will get unloaded when the module is dropped. Additionally with Pulley this isn't actually a native function pointer. This builds on bytecodealliance#9630 to prepare for future integration with Pulley to ensure that the number of locations that have to deal with bytecode-vs-native-code are minimized.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 20, 2024
This pointer is technically not safe to be a function pointer because it will get unloaded when the module is dropped. Additionally with Pulley this isn't actually a native function pointer. This builds on bytecodealliance#9630 to prepare for future integration with Pulley to ensure that the number of locations that have to deal with bytecode-vs-native-code are minimized.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
This pointer is technically not safe to be a function pointer because it will get unloaded when the module is dropped. Additionally with Pulley this isn't actually a native function pointer. This builds on #9630 to prepare for future integration with Pulley to ensure that the number of locations that have to deal with bytecode-vs-native-code are minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to encapsulate the usage of a native raw pointer and in the future act as a dispatch point for invoking Pulley instead of native code.