Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Pulley on cranelift/winch-unsupported platforms #9741

Merged

Conversation

alexcrichton
Copy link
Member

This commit updates the selection of the default target used by a Config to take into account the host architecture and possibly use Pulley instead of the host target itself. The goal here is that when a target isn't explicitly configured then Wasmtime is tasked with picking a reasonable default to execute code with. If neither Winch nor Cranelift has any support then the only way to possibly execute code would be with Pulley, so in these situations pulley becomes the default target.

The goal of this change is to make testing easier on 32-bit platforms where there is no compiler support. This means we won't have to update all tests to explicitly configure pulley on unsupported platforms. Additionally this means that an eventual wasmtime executable for 32-bit platforms will use Pulley by default and won't need any extra configuration.

This commit updates the selection of the default target used by a
`Config` to take into account the host architecture and possibly use
Pulley instead of the host target itself. The goal here is that when a
target isn't explicitly configured then Wasmtime is tasked with picking
a reasonable default to execute code with. If neither Winch nor
Cranelift has any support then the only way to possibly execute code
would be with Pulley, so in these situations pulley becomes the default
target.

The goal of this change is to make testing easier on 32-bit platforms
where there is no compiler support. This means we won't have to update
all tests to explicitly configure pulley on unsupported platforms.
Additionally this means that an eventual `wasmtime` executable for
32-bit platforms will use Pulley by default and won't need any extra
configuration.
@alexcrichton alexcrichton requested a review from a team as a code owner December 5, 2024 01:49
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team December 5, 2024 01:49
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@fitzgen fitzgen added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024
@alexcrichton alexcrichton added this pull request to the merge queue Dec 5, 2024
Merged via the queue into bytecodealliance:main with commit a4bfdc1 Dec 5, 2024
42 checks passed
@alexcrichton alexcrichton deleted the pulley-default-target branch December 5, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants