[DWARF] Fix debug intrinsics on Linux #9866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingleAccretion
force-pushed
the
DI-Fix
branch
2 times, most recently
from
1277ec5 to
c7b9783
Compare
This would have caught the issue in CI. It is also closer to what the end user will use.
SingleAccretion
force-pushed
the
DI-Fix
branch
from
c7b9783 to
3c7ae0d
Compare
SingleAccretion
requested review from
alexcrichton
and removed request for
a team
github-actions
bot
added
the
wasmtime:api
alexcrichton
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9857.
Switches the CI testing for DI to use
--release, to increase the likelihood of this kind of issue being caught early next time.Another policy which would've caught this early is enabling warn-as-error for C code. But that would be a larger change.