feat: Add hexadecimal notation support for integer arguments #9989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for parsing hexadecimal integers (prefixed with 0x or 0X) when passing arguments to WebAssembly functions. This enhancement allows users to specify integer arguments in both decimal and hexadecimal formats. For example: - Decimal: 42 - Hexadecimal: 0x2A or 0x2a The change affects both i32 and i64 argument types while maintaining backward compatibility with decimal notation.
|
Thanks! Mind adding a test for this as well? (probably somewhere in |
Defines a module with a single function sum Takes two i32 parameters and returns their sum Uses basic WebAssembly instructions to add the numbers
Builds a WebAssembly module from our WAT file Invokes the sum function with two hexadecimal numbers (0x2A and 0xFF) Verifies that the output is correct (297, which is 42 + 255)
Thank you for the answer. I did what you asked |
alexcrichton
approved these changes
Jan 13, 2025
|
(I think there's a test failure though?) |
Yes)) Gonna correct it soon |
|
Looks like there are still some failing CI jobs that need to be fixed before this can merge. |
Working on it)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parsing hexadecimal integers (prefixed with 0x or 0X) when passing arguments to WebAssembly functions. This enhancement allows users to specify integer arguments in both decimal and hexadecimal formats.
For example:
The change affects both i32 and i64 argument types while maintaining backward compatibility with decimal notation.