Initial fixed size list implementation #1277
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+310
to
+323
| /// Pops all fields for a fixed list off the stack and then composes them | ||
| /// into an array. | ||
| FixedSizeListLift { | ||
| element: &'a Type, | ||
| size: u32, | ||
| id: TypeId, | ||
| } : [*size as usize] => [1], | ||
|
|
||
| /// Pops an array off the stack, decomposes the elements and then pushes them onto the stack. | ||
| FixedSizeListLower { | ||
| element: &'a Type, | ||
| size: u32, | ||
| id: TypeId, | ||
| } : [1] => [*size as usize], |
There was a problem hiding this comment.
For this I'll echo some of my thoughts on the sibling PRs: I think we'll want to have this with a different shape where the size of the list isn't affecting the O(...) processing here. For example this is pushing/popping the list items from the operand stack of the ABI code, but I think we're going to want something different more akin to how dynamically sized lists work to avoid generating an exponential amount of code in the code generators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See WebAssembly/component-model#384 for the commit which added fixed size lists to the component model standard documents.