Skip to content

Conversation

@asteurer
Copy link
Contributor

@asteurer asteurer commented Jan 4, 2026

Overview

This closes #1484

Usage

Since the Go package hasn't yet been set up, you can try the new functionality by replacing the following line in the generated wit_component go.mod file:

module wit_component

go 1.25

- replace github.com/bytecodealliance/wit-bindgen => github.com/bytecodealliance/wit-bindgen/crates/go/src/package v0.50.0
+ replace github.com/bytecodealliance/wit-bindgen => github.com/asteurer/wit-bindgen/crates/go/src/package v0.50.0

@dicej

@asteurer asteurer force-pushed the package branch 10 times, most recently from b8feb32 to a2f25bf Compare January 5, 2026 18:24
Copy link
Collaborator

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! LGTM overall; just a few comments inline.

@asteurer asteurer force-pushed the package branch 3 times, most recently from ffc1ee4 to b543a78 Compare January 5, 2026 18:44
@asteurer asteurer requested a review from dicej January 5, 2026 18:45
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
@dicej
Copy link
Collaborator

dicej commented Jan 5, 2026

@asteurer When I run the tests locally and then run git diff, I see:

diff --git a/wit_component/go.mod b/wit_component/go.mod
index 1376492c..dd0a084c 100644
--- a/wit_component/go.mod
+++ b/wit_component/go.mod
@@ -2,4 +2,4 @@ module wit_component

 go 1.25

-replace github.com/bytecodealliance/wit-bindgen => /home/asteurer/repos/wit-bindgen/crates/go/src/package
+replace github.com/bytecodealliance/wit-bindgen => /home/dicej/p/wit-bindgen/crates/go/src/package

Is there a way we could avoid putting local paths in a file tracked by Git?

@asteurer
Copy link
Contributor Author

asteurer commented Jan 5, 2026

@dicej 🤦 That's an artifact from the runtime test that snuck in. I'll remove that real quick

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
@dicej dicej requested a review from alexcrichton January 5, 2026 19:52
@dicej
Copy link
Collaborator

dicej commented Jan 5, 2026

@alexcrichton any concerns about the new CI step (or any other aspect of this PR)?

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alexcrichton alexcrichton added this pull request to the merge queue Jan 5, 2026
Merged via the queue into bytecodealliance:main with commit 0d6a753 Jan 5, 2026
25 checks passed
@asteurer asteurer deleted the package branch January 5, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

go: Duplicated definitions error

3 participants