Add runtime test for options #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
reviewed
Jan 31, 2024
There was a problem hiding this comment.
LGTM, but need to run cargo fmt.
@alexcrichton for context, when we were adding Option support to c#(#820) I noticed we didn't have a way to run any runtime tests since we don't fully support all the types where options are used. I thought having a test like this makes it easier to adopt types in iterative fashion for future languages and have runtime tests not just code-gen.
|
Sounds good to me! Definitely feel free to add whatever tests you like and if they only have one C# guest that's no problem, other guests can fill in implementations as necessary over time. |
jsturtevant
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently tests for options are embedded in other tests, this adds a dedicated runtime test for options.
cc: @jsturtevant