Update dependencies, wasmtime-19, remove wasmtime-wasi #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess I'll bump to 19.0.1 ;) |
guybedford
approved these changes
Apr 3, 2024
fitzgen
requested changes
Apr 4, 2024
| ValType::ExternRef => Val::ExternRef(None), | ||
| ValType::FuncRef => Val::FuncRef(None), | ||
| ValType::Ref(ref_type) => { | ||
| if ref_type.matches(&RefType::EXTERNREF) { |
There was a problem hiding this comment.
Can you check whether ref_type.is_nullable() and return an error here ("cannot create a dummy value for a non-nullable reference type") if so? This will require making a few of these dummy_foo functions return Result<Foo>s.
Gentle
commented
Apr 5, 2024
src/dummy.rs
Outdated
| } | ||
|
|
||
| /// Construct a sequence of dummy values for the given types. | ||
| #[cfg(fuzzing)] | ||
| pub fn dummy_values(val_tys: impl IntoIterator<Item = ValType>) -> Vec<Val> { | ||
| val_tys.into_iter().map(dummy_value).collect() | ||
| val_tys |
There was a problem hiding this comment.
this is the only place where dummy_value is called
fitzgen
reviewed
Apr 8, 2024
|
I run the fuzzer with otherwise I hope I got the dummy values part right this time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasmtime-wasi is no longer used since the preview1 host has moved to wasi-common
I'm not sure if my changes to dummy.rs are correct, I read your notes on the RefType changes, is it fine to treat NULLFUNCREF the same as FUNCREF?
the fuzzer ran out of memory at some point once, I think I just let it run for too long and couldn't reproduce the error a second time