Fix Intel Mac CI builds. #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
approved these changes
Sep 5, 2024
We build both x86-64 and aarch64 ("Intel Mac" and "Apple Silicon Mac")
binaries for wizer in CI on the `macos-latest` CI runner. Historically,
this runner was an x86-64 machine, so while we could do a direct compile
for x86-64 binaries, we added a target override for `aarch64-darwin` for
the aarch64 builds to force a cross-compile.
When GitHub switched macOS CI runners to aarch64 (ARM64) machines
somewhat recently, the `macos-latest` runner image began producing
aarch64 binaries by default, and the target override for
cross-compilation became meaningless (redundant). As a result, *both* of
our x86-64 and aarch64 macOS binary artifacts contained aarch64
binaries. This is a problem for anyone running an Intel Mac.
This PR switches the CI config to specify a cross-compilation of x86-64
binaries, so each target builds its proper architecture.
cfallin
force-pushed
the
cfallin/fix-intel-macos-ci
branch
from
8aa70b2 to
c991cca
Compare
cfallin
force-pushed
the
cfallin/fix-intel-macos-ci
branch
from
9101ca8 to
82f0bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We build both x86-64 and aarch64 ("Intel Mac" and "Apple Silicon Mac") binaries for wizer in CI on the
macos-latestCI runner. Historically, this runner was an x86-64 machine, so while we could do a direct compile for x86-64 binaries, we added a target override foraarch64-darwinfor the aarch64 builds to force a cross-compile.When GitHub switched macOS CI runners to aarch64 (ARM64) machines somewhat recently, the
macos-latestrunner image began producing aarch64 binaries by default, and the target override for cross-compilation became meaningless (redundant). As a result, both of our x86-64 and aarch64 macOS binary artifacts contained aarch64 binaries. This is a problem for anyone running an Intel Mac.This PR switches the CI config to specify a cross-compilation of x86-64 binaries, so each target builds its proper architecture.