Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BitSail] Pref regex pattern #150

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

NiuXiangQian
Copy link
Contributor

@NiuXiangQian NiuXiangQian commented Nov 9, 2022

Signed-off-by:

Pre-Checklist

Note: Please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests.

Purpose

1、The precompile function can effectively speed up the regular matching speed
2、fix docs

Some description about what this PR wants to do.

Approaches

<! --
Describe how this PR achieve the mentioned purpose in a few senteces.
-->

Some description about how this PR achives the purpose.

Related Issues

<! --
Will this PR close any open issue? If yes, would you please mention the issue(s) here?
-->

_e.g. _ Close #796

New Behavior (screenshots if needed)

<! --
Describe the newly updated behavior, if relevant.
-->

N/A

@NiuXiangQian NiuXiangQian changed the title Pref regex pattern [BitSail] Pref regex pattern Nov 9, 2022
Copy link
Collaborator

@garyli1019 garyli1019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution. Will merge once CICD pass

@garyli1019 garyli1019 merged commit e4923a1 into bytedance:master Nov 9, 2022
@BlockLiu
Copy link
Collaborator

Hi @NiuXiangQian, thanks for your contribution to the BitSail community. Would you like to join contributor chat group? Here is the QR code. If it expires, you can leave a message here. Look forward to your coming!
ContributorGroup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants