Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BitSail][Connector] Support more send method in Kafka writer #164

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

zeliu
Copy link
Contributor

@zeliu zeliu commented Nov 11, 2022

Signed-off-by:

Pre-Checklist

Note: Please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests.

Purpose

Support more send method in Kafka writer

Approaches

Support more send method in Kafka writer

Related Issues

#147

New Behavior (screenshots if needed)

N/A

@zeliu
Copy link
Contributor Author

zeliu commented Nov 14, 2022

hi @BlockLiu ,It seems that there is something wrong with the network.

Error: Failed to execute goal on project connector-fake: Could not resolve dependencies for project com.bytedance.bitsail:connector-fake:jar:0.1.0-SNAPSHOT: Could not transfer artifact net.datafaker:datafaker:jar:1.6.0 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/net/datafaker/datafaker/1.6.0/datafaker-1.6.0.jar: Connection timed out (Read failed) -> [Help 1]

@BlockLiu
Copy link
Collaborator

BlockLiu commented Nov 15, 2022

The error message means failing to download maven dependency, which may be caused by network problems or something.
Just retrying the failed CICD test is ok.

Copy link
Collaborator

@BlockLiu BlockLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@BlockLiu BlockLiu merged commit c55bfdd into bytedance:master Nov 15, 2022
BlockLiu added a commit that referenced this pull request Nov 15, 2022
@hk-lrzy
Copy link
Collaborator

hk-lrzy commented Nov 16, 2022

@zeliu hi guys, thanks for you PR, we plan to build a group for all contributor, here is link,
image
welcome to join us~

@zeliu zeliu deleted the dev branch November 30, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants