[BitSail][core]fixed row utils high cpu usage issue. #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hk-lrzy
changed the title
garyli1019
reviewed
Nov 22, 2022
...il-cores/bitsail-core-flink/src/main/java/com/bytedance/bitsail/flink/core/util/RowUtil.java
Show resolved
Hide resolved
garyli1019
approved these changes
Nov 22, 2022
garyli1019
reviewed
Nov 23, 2022
...il-cores/bitsail-core-flink/src/main/java/com/bytedance/bitsail/flink/core/util/RowUtil.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by:
Pre-Checklist
Note: Please complete ALL items in the following checklist.
Purpose
In history, we use
RowUtilto calcalate object size for the reader and writer side. In most case we directly return the constants for the object, but when we we meet object likebigdecimalorbigintegeror any object else, we will try useObjectSizeCalculator.getObjectSizeto calcualte object size.ObjectSizeCalculator.getObjectSizeis simple enought to let us get real object size, but it will consumer more CPU usage than we think.We compare the profile usage between the
ObjectSizeCalculator.getObjectSizeandconstants value, it show there will have 50% extra CPU usgae in theObjectSizeCalculator.getObjectSizecase.Some description about what this PR wants to do.
Approaches
Some description about how this PR achives the purpose.
Related Issues
e.g. Close #796
New Behavior (screenshots if needed)
N/A