Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make rustfmt and clippy happy #279

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Aug 2, 2024

This PR will fix CI on the main branch.

Signed-off-by: Xuanwo <github@xuanwo.io>
@CLAassistant
Copy link

CLAassistant commented Aug 2, 2024

CLA assistant check
All committers have signed the CLA.

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Aug 2, 2024

tests failed for:

  = note: /rust/lib/rustlib/i686-unknown-linux-gnu/lib/libstd-0574b0e9069601fe.rlib(std-0574b0e9069601fe.std.4ab0ec8107713975-cgu.0.rcgu.o): In function `std::sys::pal::unix::fs::try_statx::statx::h80cd69578a9fda62':
          /rustc/051478957371ee0084a7c0913941d2a8c4757bb9/library/std/src/sys/pal/unix/weak.rs:169: undefined reference to `statx'

@Xuanwo Xuanwo changed the title chore: Make rustfmt happy ci: Make rustfmt and clippy happy Aug 2, 2024
@Xuanwo Xuanwo marked this pull request as draft August 2, 2024 07:26
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review August 2, 2024 07:59
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Aug 2, 2024

More format and clippy issues have been fixed in this PR. The remaing issues #281 and #280 are not related.

I believe this PR itself is good to go.

Copy link
Member

@ihciah ihciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ihciah ihciah merged commit 874bcb1 into bytedance:master Aug 2, 2024
17 of 28 checks passed
@Xuanwo Xuanwo deleted the format-code branch August 2, 2024 08:04
renovate bot referenced this pull request in spiraldb/vortex Aug 20, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [monoio](https://togithub.com/bytedance/monoio) |
workspace.dependencies | patch | `0.2.3` -> `0.2.4` |

---

### Release Notes

<details>
<summary>bytedance/monoio (monoio)</summary>

### [`v0.2.4`](https://togithub.com/bytedance/monoio/releases/tag/0.2.4)

[Compare
Source](https://togithub.com/bytedance/monoio/compare/0.2.3...0.2.4)

#### What's Changed

- readme: typo fix by [@&#8203;tshepang](https://togithub.com/tshepang)
in
[https://github.com/bytedance/monoio/pull/258](https://togithub.com/bytedance/monoio/pull/258)
- enhance: remove redundant check and improve efficiency by
[@&#8203;ihciah](https://togithub.com/ihciah) in
[https://github.com/bytedance/monoio/pull/260](https://togithub.com/bytedance/monoio/pull/260)
- fix: read_u128\_le() returns u16 instead of u128 . by
[@&#8203;liuxin231](https://togithub.com/liuxin231) in
[https://github.com/bytedance/monoio/pull/262](https://togithub.com/bytedance/monoio/pull/262)
- Fix docs.rs build by [@&#8203;hatoo](https://togithub.com/hatoo) in
[https://github.com/bytedance/monoio/pull/264](https://togithub.com/bytedance/monoio/pull/264)
- Feat: BoxFuture which implements Send by
[@&#8203;har23k](https://togithub.com/har23k) in
[https://github.com/bytedance/monoio/pull/271](https://togithub.com/bytedance/monoio/pull/271)
- ci/fix: modify ci.yml to let `cargo fmt/clippy` only runs on nightly
channel by [@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) in
[https://github.com/bytedance/monoio/pull/273](https://togithub.com/bytedance/monoio/pull/273)
- feat(op, fs): ✨ Intergated `statx` into monoio by
[@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) in
[https://github.com/bytedance/monoio/pull/268](https://togithub.com/bytedance/monoio/pull/268)
- ci: Make rustfmt and clippy happy by
[@&#8203;Xuanwo](https://togithub.com/Xuanwo) in
[https://github.com/bytedance/monoio/pull/279](https://togithub.com/bytedance/monoio/pull/279)
- docs: correct JoinHandle link in the doc of spawn() by
[@&#8203;SteveLauC](https://togithub.com/SteveLauC) in
[https://github.com/bytedance/monoio/pull/265](https://togithub.com/bytedance/monoio/pull/265)
- ci: using main branch of cross by
[@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) in
[https://github.com/bytedance/monoio/pull/283](https://togithub.com/bytedance/monoio/pull/283)
- make clippy happy by [@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt)
in
[https://github.com/bytedance/monoio/pull/284](https://togithub.com/bytedance/monoio/pull/284)
- ci: Disable test for i686 unknown linux target by
[@&#8203;Xuanwo](https://togithub.com/Xuanwo) in
[https://github.com/bytedance/monoio/pull/286](https://togithub.com/bytedance/monoio/pull/286)
- fix: don't register file fd in `File::from_std` by
[@&#8203;NKID00](https://togithub.com/NKID00) in
[https://github.com/bytedance/monoio/pull/277](https://togithub.com/bytedance/monoio/pull/277)
- feat(op, fs): ✨ add `MkDirAt` opcode in io-uring and
`create_dir(_all)` by [@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) in
[https://github.com/bytedance/monoio/pull/270](https://togithub.com/bytedance/monoio/pull/270)
- feat: unlink op, remove_file and remove_dir by
[@&#8203;NKID00](https://togithub.com/NKID00) in
[https://github.com/bytedance/monoio/pull/288](https://togithub.com/bytedance/monoio/pull/288)
- feat: support `opcode::RenameAt` by
[@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) in
[https://github.com/bytedance/monoio/pull/289](https://togithub.com/bytedance/monoio/pull/289)

#### New Contributors

- [@&#8203;tshepang](https://togithub.com/tshepang) made their first
contribution in
[https://github.com/bytedance/monoio/pull/258](https://togithub.com/bytedance/monoio/pull/258)
- [@&#8203;liuxin231](https://togithub.com/liuxin231) made their first
contribution in
[https://github.com/bytedance/monoio/pull/262](https://togithub.com/bytedance/monoio/pull/262)
- [@&#8203;hatoo](https://togithub.com/hatoo) made their first
contribution in
[https://github.com/bytedance/monoio/pull/264](https://togithub.com/bytedance/monoio/pull/264)
- [@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) made their first
contribution in
[https://github.com/bytedance/monoio/pull/273](https://togithub.com/bytedance/monoio/pull/273)
- [@&#8203;Xuanwo](https://togithub.com/Xuanwo) made their first
contribution in
[https://github.com/bytedance/monoio/pull/279](https://togithub.com/bytedance/monoio/pull/279)
- [@&#8203;SteveLauC](https://togithub.com/SteveLauC) made their first
contribution in
[https://github.com/bytedance/monoio/pull/265](https://togithub.com/bytedance/monoio/pull/265)
- [@&#8203;NKID00](https://togithub.com/NKID00) made their first
contribution in
[https://github.com/bytedance/monoio/pull/277](https://togithub.com/bytedance/monoio/pull/277)

**Full Changelog**:
bytedance/monoio@0.2.3...0.2.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/spiraldb/vortex).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants