Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some doc test error #290

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix some doc test error #290

merged 2 commits into from
Aug 21, 2024

Conversation

Lzzzzzt
Copy link
Collaborator

@Lzzzzzt Lzzzzzt commented Aug 21, 2024

This PR is done by finishing the following tasks:

  • fix some doc test error in monoio/src/fs/mod.rs
  • change some visibility of some struct
  • fix typo in fs_rename.rs (thanks @NKID00 to find this typo)

@Lzzzzzt
fix: fix some doc test error
28d297b 
Signed-off-by: lzzzt <liuzitao0123@gmail.com>
@Lzzzzzt
refactor: fix typo
368299e 
Signed-off-by: lzzzt <liuzitao0123@gmail.com>
Xuanwo
Xuanwo approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit e7a6dc1 into bytedance:master Aug 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lzzzzzt @Xuanwo