Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat & refactor(!): Change Default Blocking Handle Behavior & Add Basic Read Op #305

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

Lzzzzzt
Copy link
Collaborator

@Lzzzzzt Lzzzzzt commented Sep 21, 2024

Change Default Blocking Handle Behavior.
Add basic "asyncified" read operations.

This PR is part of #304 and done by finishing the following tasks:

  • Change the default blocking handle behavior from panic to execute local.
  • Support file's read operation on unix and windows.
  • Add test for these operations.
  • Enable CI run test of these operations.

Other details are shown in the code.

Signed-off-by: lzzzt <liuzitao0123@gmail.com>

ci: enable CI run test with legacy + sync

Signed-off-by: lzzzt <liuzitao0123@gmail.com>
ihciah
ihciah previously approved these changes Sep 23, 2024
@Lzzzzzt Lzzzzzt changed the title feat: Add basic read op feat & refactor(!): Change Default Blocking Handle Behavior & Add Basic Read Op Sep 24, 2024
@Lzzzzzt Lzzzzzt marked this pull request as draft September 24, 2024 12:13
@Lzzzzzt Lzzzzzt force-pushed the asyncify branch 2 times, most recently from 3184d27 to 00ae946 Compare September 24, 2024 13:14
@Lzzzzzt Lzzzzzt marked this pull request as ready for review September 24, 2024 13:28
@Lzzzzzt Lzzzzzt requested a review from ihciah September 24, 2024 13:30
ihciah
ihciah previously approved these changes Oct 12, 2024
Copy link
Member

@ihciah ihciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very great work!

monoio/src/driver/op/read.rs Outdated Show resolved Hide resolved
Signed-off-by: lzzzt <liuzitao0123@gmail.com>
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
@ihciah ihciah merged commit 9bd5935 into bytedance:master Oct 15, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants