feat: ignore SIGPROF while calling native funcs

bytedance · Dec 29, 2022 · 782121b · 782121b
1 parent f421ee8
commit 782121b
Show file tree

Hide file tree

Showing 5 changed files with 52 additions and 6 deletions.
diff --git a/ast/parser.go b/ast/parser.go
@@ -319,7 +319,9 @@ func (self *Parser) Parse() (Node, types.ParsingError) {
 
 func (self *Parser) skip() (int, types.ParsingError) {
     fsm := types.NewStateMachine()
+    rt.StopProf()
     start := native.SkipOne(&self.s, &self.p, fsm, uint64(0))
+    rt.StartProf()
     types.FreeStateMachine(fsm)
 
     if start < 0 {

diff --git a/decoder/primitives.go b/decoder/primitives.go
@@ -30,7 +30,10 @@ func decodeTypedPointer(s string, i int, vt *rt.GoType, vp unsafe.Pointer, sb *_
         return 0, err
     } else {
         rt.MoreStack(_FP_size + _VD_size + native.MaxFrameSize)
-        return fn(s, i, vp, sb, fv, "", nil)
+        rt.StopProf()
+        ret, err := fn(s, i, vp, sb, fv, "", nil)
+        rt.StartProf()
+        return ret, err
     }
 }
 

diff --git a/encoder/primitives.go b/encoder/primitives.go
@@ -72,10 +72,16 @@ func encodeTypedPointer(buf *[]byte, vt *rt.GoType, vp *unsafe.Pointer, sb *_Sta
         return err
     } else if vt.Indirect() {
         rt.MoreStack(_FP_size + native.MaxFrameSize)
-        return fn(buf, *vp, sb, fv)
+        rt.StopProf()
+        err := fn(buf, *vp, sb, fv)
+        rt.StartProf()
+        return err
     } else {
         rt.MoreStack(_FP_size + native.MaxFrameSize)
-        return fn(buf, unsafe.Pointer(vp), sb, fv)
+        rt.StopProf()
+        err := fn(buf, unsafe.Pointer(vp), sb, fv)
+        rt.StartProf()
+        return err
     }
 }
 

diff --git a/internal/rt/fastmem.go b/internal/rt/fastmem.go
@@ -65,6 +65,3 @@ func FuncAddr(f interface{}) unsafe.Pointer {
         return *(*unsafe.Pointer)(vv.Value)
     }
 }
-
-//go:nosplit
-func MoreStack(size uintptr)
diff --git a/internal/rt/gcwb.go b/internal/rt/gcwb.go
@@ -74,3 +74,41 @@ func GcwbAddr() uintptr {
         return uintptr(fp) + off
     }
 }
+
+// WARN: must be aligned with runtime.Prof
+type Prof struct {
+    signalLock uint32
+	hz int32
+}
+
+var (
+    //go:linkname runtimeProf runtime.prof
+    runtimeProf Prof
+
+    // count of native-C calls
+    yieldCount uint32
+
+    // previous value of runtimeProf.hz
+    oldHz int32
+)
+
+//go:nosplit
+func MoreStack(size uintptr)
+
+func StopProf() {
+    atomic.AddUint32(&yieldCount, 1)
+    if runtimeProf.hz != 0 {
+        oldHz = runtimeProf.hz
+        runtimeProf.hz = 0
+    }
+}
+
+func StartProf() {
+    atomic.AddUint32(&yieldCount, ^uint32(0))
+    if yieldCount == 0 && runtimeProf.hz == 0 {
+        if oldHz == 0 {
+            oldHz = 100
+        }
+        runtimeProf.hz = oldHz
+    }
+}