Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: marshal struct field with "omitempty" tag as encoding/json #114

Merged
merged 1 commit into from
Oct 12, 2021
Merged

fix: marshal struct field with "omitempty" tag as encoding/json #114

merged 1 commit into from
Oct 12, 2021

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Oct 11, 2021

This fixes #113.

@liuq19 liuq19 marked this pull request as ready for review October 11, 2021 08:16
@liuq19 liuq19 force-pushed the bugfix/omitempty_tag branch 2 times, most recently from 547c784 to e84460e Compare October 12, 2021 04:56
@liuq19 liuq19 force-pushed the bugfix/omitempty_tag branch from e84460e to 6c56017 Compare October 12, 2021 07:06
@liuq19 liuq19 merged commit 3eca433 into main Oct 12, 2021
@liuq19 liuq19 deleted the bugfix/omitempty_tag branch October 12, 2021 07:14
@liuq19 liuq19 mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsterDY AsterDY AsterDY approved these changes

@chenzhuoyu chenzhuoyu chenzhuoyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

not consistent with encoding/json when marshalling struct field with "omitempty" tag
3 participants
@liuq19 @chenzhuoyu @AsterDY