Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env option SONIC_STOP_PROFILING to stop profiling on demands #361

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Feb 14, 2023

what this PR for?

  • as Panic: invalid pc-encoded table #310 mentioned, go traceback while calling native functions may cause sonic crash. Therefore we commit PR feat: stop sigprof while calling native #342 to prevent this ahead. However, it will make profiling results inaccurate, especially when sonic is heavily used.
  • Thus, we add an environmental variant SONIC_STOP_PROFILING to control if StopProf feature should open, which only works when this variant is not empty

@AsterDY AsterDY changed the title feat: add env option SONIC_STOP_PROFILING to stop traceback on demands feat: add env option SONIC_STOP_PROFILING to stop profiling on demands Feb 14, 2023
@AsterDY AsterDY merged commit fa82a64 into main Feb 14, 2023
@AsterDY AsterDY deleted the feat/stop_prof_env branch February 14, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants