Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: omit checkptr detects on unsafe functions #372

Merged
merged 2 commits into from
Feb 28, 2023
Merged

build: omit checkptr detects on unsafe functions #372

merged 2 commits into from
Feb 28, 2023

Conversation

AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Feb 28, 2023

No description provided.

github-actions[bot]
github-actions bot reviewed Feb 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 302 files.

Valid Invalid Ignored Fixed
6 203 93 0
Click to see the invalid file list
  • api.go
  • ast/api_amd64.go
  • ast/api_amd64_test.go
  • ast/api_compat.go
  • ast/decode.go
  • ast/encode.go
  • ast/encode_test.go
  • ast/error.go
  • ast/iterator.go
  • ast/iterator_test.go
  • ast/node.go
  • ast/node_test.go
  • ast/parser.go
  • ast/parser_test.go
  • ast/search.go
  • ast/search_test.go
  • ast/sort.go
  • ast/stubs_go115.go
  • ast/stubs_go120.go
  • ast/testdata_test.go
  • compat.go
  • compat_test.go
  • decode_float_test.go
  • decode_test.go
  • decoder/assembler_amd64_go116.go
  • decoder/assembler_amd64_go117.go
  • decoder/assembler_test.go
  • decoder/compiler.go
  • decoder/compiler_test.go
  • decoder/debug.go
  • decoder/decoder.go
  • decoder/decoder_test.go
  • decoder/errors.go
  • decoder/errors_test.go
  • decoder/generic_amd64_go116.go
  • decoder/generic_amd64_go117.go
  • decoder/generic_amd64_go117_test.s
  • decoder/generic_amd64_test.s
  • decoder/generic_test.go
  • decoder/norace_test.go
  • decoder/pools.go
  • decoder/primitives.go
  • decoder/stream.go
  • decoder/stream_test.go
  • decoder/stubs_go115.go
  • decoder/stubs_go120.go
  • decoder/testdata_test.go
  • decoder/types.go
  • decoder/utils.go
  • encode_test.go
  • encoder/assembler_amd64_go116.go
  • encoder/assembler_amd64_go117.go
  • encoder/assembler_test.go
  • encoder/compiler.go
  • encoder/compiler_test.go
  • encoder/debug_go116.go
  • encoder/debug_go117.go
  • encoder/encoder.go
  • encoder/encoder_test.go
  • encoder/errors.go
  • encoder/mapiter.go
  • encoder/pools.go
  • encoder/primitives.go
  • encoder/sort.go
  • encoder/sort_test.go
  • encoder/stream.go
  • encoder/stream_test.go
  • encoder/stubs_go116.go
  • encoder/stubs_go117.go
  • encoder/stubs_go120.go
  • encoder/testdata_test.go
  • encoder/types.go
  • encoder/utils.go
  • external_jsonlib_test/benchmark_test/decoder_stream_test.go
  • external_jsonlib_test/benchmark_test/decoder_test.go
  • external_jsonlib_test/benchmark_test/encoder_stream_test.go
  • external_jsonlib_test/benchmark_test/encoder_test.go
  • external_jsonlib_test/benchmark_test/parser_test.go
  • external_jsonlib_test/benchmark_test/search_test.go
  • external_jsonlib_test/benchmark_test/testdata_test.go
  • external_jsonlib_test/unit_test/api_test.go
  • external_jsonlib_test/unit_test/ast_compat_test.go
  • external_jsonlib_test/unit_test/decoder_stream_test.go
  • fuzz/ast_fuzz_test.go
  • fuzz/corpus.go
  • fuzz/fuzz_test.go
  • fuzz/other_fuzz_test.go
  • fuzz/struct_fuzz_test.go
  • generic_test/benchmark_test.go
  • generic_test/sonic_test.go
  • generic_test/testdata_test.go
  • internal/caching/fcache.go
  • internal/caching/hashing.go
  • internal/caching/hashing_test.go
  • internal/caching/pcache.go
  • internal/caching/pcache_test.go
  • internal/cpu/features.go
  • internal/jit/arch_amd64.go
  • internal/jit/assembler_amd64.go
  • internal/jit/backend.go
  • internal/jit/backend_test.go
  • internal/jit/runtime.go
  • internal/loader/funcdata.go
  • internal/loader/funcdata_go115.go
  • internal/loader/funcdata_go116.go
  • internal/loader/funcdata_go118.go
  • internal/loader/funcdata_go120.go
  • internal/loader/loader.go
  • internal/loader/loader_go117_test.go
  • internal/loader/loader_test.go
  • internal/loader/loader_windows.go
  • internal/native/avx/fastfloat_amd64_test.go
  • internal/native/avx/fastint_amd64_test.go
  • internal/native/avx/native_amd64.go
  • internal/native/avx/native_amd64_test.go
  • internal/native/avx/native_export_amd64.go
  • internal/native/avx2/fastfloat_amd64_test.go
  • internal/native/avx2/fastint_amd64_test.go
  • internal/native/avx2/native_amd64.go
  • internal/native/avx2/native_amd64_test.go
  • internal/native/avx2/native_export_amd64.go
  • internal/native/dispatch_amd64.go
  • internal/native/dispatch_amd64.s
  • internal/native/sse/fastfloat_amd64_test.go
  • internal/native/sse/fastint_amd64_test.go
  • internal/native/sse/native_amd64.go
  • internal/native/sse/native_amd64.s
  • internal/native/sse/native_amd64_test.go
  • internal/native/sse/native_export_amd64.go
  • internal/native/sse/native_subr_amd64.go
  • internal/native/types/types.go
  • internal/resolver/resolver.go
  • internal/resolver/resolver_test.go
  • internal/resolver/stubs.go
  • internal/rt/asm_amd64.s
  • internal/rt/asm_arm64.s
  • internal/rt/fastmem.go
  • internal/rt/fastvalue.go
  • internal/rt/gcwb.go
  • internal/rt/int48.go
  • issue_test/hugestruct_test.go
  • issue_test/issue100_test.go
  • issue_test/issue101_test.go
  • issue_test/issue107_test.go
  • issue_test/issue108_test.go
  • issue_test/issue112_test.go
  • issue_test/issue113_test.go
  • issue_test/issue115_test.go
  • issue_test/issue119_test.go
  • issue_test/issue123_test.go
  • issue_test/issue128_test.go
  • issue_test/issue138_test.go
  • issue_test/issue141_test.go
  • issue_test/issue144_test.go
  • issue_test/issue16_test.go
  • issue_test/issue182_test.go
  • issue_test/issue186_test.go
  • issue_test/issue195_test.go
  • issue_test/issue206_test.go
  • issue_test/issue213_test.go
  • issue_test/issue242_test.go
  • issue_test/issue248_test.go
  • issue_test/issue258_test.go
  • issue_test/issue263_test.go
  • issue_test/issue273_test.go
  • issue_test/issue27_test.go
  • issue_test/issue293_test.go
  • issue_test/issue39_test.go
  • issue_test/issue3_test.go
  • issue_test/issue45_test.go
  • issue_test/issue58_test.go
  • issue_test/issue5_test.go
  • issue_test/issue67_test.go
  • issue_test/issue76_test.go
  • issue_test/issue7_test.go
  • issue_test/issue82_test.go
  • issue_test/issue83_test.go
  • issue_test/issue8_test.go
  • issue_test/issue90_test.go
  • issue_test/issue93_test.go
  • issue_test/issue98_test.go
  • issue_test/issue_recurse_test.go
  • issue_test/plugin/main.go
  • issue_test/plugin_test.go
  • issue_test/pretouch_test.go
  • issue_test/testmain_test.go
  • loader/funcdata_go115.go
  • loader/funcdata_go116.go
  • loader/funcdata_go118.go
  • loader/funcdata_go120.go
  • loader/loader_go115.go
  • loader/loader_go116.go
  • loader/loader_go116_test.go
  • loader/loader_go117_test.go
  • loader/mmap_windows.go
  • option/option.go
  • search_test.go
  • sonic.go
  • testdata/small.go
  • unquote/unquote.go
  • use_number_test.go
  • utf8/utf8.go
  • utf8/utf8_test.go

@AsterDY AsterDY force-pushed the bugfix/omit_checkptr branch from d2d4c8f to 31e0ac9 Compare February 28, 2023 06:56
github-actions[bot]
github-actions bot reviewed Feb 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 302 files.

Valid Invalid Ignored Fixed
6 203 93 0
Click to see the invalid file list
  • api.go
  • ast/api_amd64.go
  • ast/api_amd64_test.go
  • ast/api_compat.go
  • ast/decode.go
  • ast/encode.go
  • ast/encode_test.go
  • ast/error.go
  • ast/iterator.go
  • ast/iterator_test.go
  • ast/node.go
  • ast/node_test.go
  • ast/parser.go
  • ast/parser_test.go
  • ast/search.go
  • ast/search_test.go
  • ast/sort.go
  • ast/stubs_go115.go
  • ast/stubs_go120.go
  • ast/testdata_test.go
  • compat.go
  • compat_test.go
  • decode_float_test.go
  • decode_test.go
  • decoder/assembler_amd64_go116.go
  • decoder/assembler_amd64_go117.go
  • decoder/assembler_test.go
  • decoder/compiler.go
  • decoder/compiler_test.go
  • decoder/debug.go
  • decoder/decoder.go
  • decoder/decoder_test.go
  • decoder/errors.go
  • decoder/errors_test.go
  • decoder/generic_amd64_go116.go
  • decoder/generic_amd64_go117.go
  • decoder/generic_amd64_go117_test.s
  • decoder/generic_amd64_test.s
  • decoder/generic_test.go
  • decoder/norace_test.go
  • decoder/pools.go
  • decoder/primitives.go
  • decoder/stream.go
  • decoder/stream_test.go
  • decoder/stubs_go115.go
  • decoder/stubs_go120.go
  • decoder/testdata_test.go
  • decoder/types.go
  • decoder/utils.go
  • encode_test.go
  • encoder/assembler_amd64_go116.go
  • encoder/assembler_amd64_go117.go
  • encoder/assembler_test.go
  • encoder/compiler.go
  • encoder/compiler_test.go
  • encoder/debug_go116.go
  • encoder/debug_go117.go
  • encoder/encoder.go
  • encoder/encoder_test.go
  • encoder/errors.go
  • encoder/mapiter.go
  • encoder/pools.go
  • encoder/primitives.go
  • encoder/sort.go
  • encoder/sort_test.go
  • encoder/stream.go
  • encoder/stream_test.go
  • encoder/stubs_go116.go
  • encoder/stubs_go117.go
  • encoder/stubs_go120.go
  • encoder/testdata_test.go
  • encoder/types.go
  • encoder/utils.go
  • external_jsonlib_test/benchmark_test/decoder_stream_test.go
  • external_jsonlib_test/benchmark_test/decoder_test.go
  • external_jsonlib_test/benchmark_test/encoder_stream_test.go
  • external_jsonlib_test/benchmark_test/encoder_test.go
  • external_jsonlib_test/benchmark_test/parser_test.go
  • external_jsonlib_test/benchmark_test/search_test.go
  • external_jsonlib_test/benchmark_test/testdata_test.go
  • external_jsonlib_test/unit_test/api_test.go
  • external_jsonlib_test/unit_test/ast_compat_test.go
  • external_jsonlib_test/unit_test/decoder_stream_test.go
  • fuzz/ast_fuzz_test.go
  • fuzz/corpus.go
  • fuzz/fuzz_test.go
  • fuzz/other_fuzz_test.go
  • fuzz/struct_fuzz_test.go
  • generic_test/benchmark_test.go
  • generic_test/sonic_test.go
  • generic_test/testdata_test.go
  • internal/caching/fcache.go
  • internal/caching/hashing.go
  • internal/caching/hashing_test.go
  • internal/caching/pcache.go
  • internal/caching/pcache_test.go
  • internal/cpu/features.go
  • internal/jit/arch_amd64.go
  • internal/jit/assembler_amd64.go
  • internal/jit/backend.go
  • internal/jit/backend_test.go
  • internal/jit/runtime.go
  • internal/loader/funcdata.go
  • internal/loader/funcdata_go115.go
  • internal/loader/funcdata_go116.go
  • internal/loader/funcdata_go118.go
  • internal/loader/funcdata_go120.go
  • internal/loader/loader.go
  • internal/loader/loader_go117_test.go
  • internal/loader/loader_test.go
  • internal/loader/loader_windows.go
  • internal/native/avx/fastfloat_amd64_test.go
  • internal/native/avx/fastint_amd64_test.go
  • internal/native/avx/native_amd64.go
  • internal/native/avx/native_amd64_test.go
  • internal/native/avx/native_export_amd64.go
  • internal/native/avx2/fastfloat_amd64_test.go
  • internal/native/avx2/fastint_amd64_test.go
  • internal/native/avx2/native_amd64.go
  • internal/native/avx2/native_amd64_test.go
  • internal/native/avx2/native_export_amd64.go
  • internal/native/dispatch_amd64.go
  • internal/native/dispatch_amd64.s
  • internal/native/sse/fastfloat_amd64_test.go
  • internal/native/sse/fastint_amd64_test.go
  • internal/native/sse/native_amd64.go
  • internal/native/sse/native_amd64.s
  • internal/native/sse/native_amd64_test.go
  • internal/native/sse/native_export_amd64.go
  • internal/native/sse/native_subr_amd64.go
  • internal/native/types/types.go
  • internal/resolver/resolver.go
  • internal/resolver/resolver_test.go
  • internal/resolver/stubs.go
  • internal/rt/asm_amd64.s
  • internal/rt/asm_arm64.s
  • internal/rt/fastmem.go
  • internal/rt/fastvalue.go
  • internal/rt/gcwb.go
  • internal/rt/int48.go
  • issue_test/hugestruct_test.go
  • issue_test/issue100_test.go
  • issue_test/issue101_test.go
  • issue_test/issue107_test.go
  • issue_test/issue108_test.go
  • issue_test/issue112_test.go
  • issue_test/issue113_test.go
  • issue_test/issue115_test.go
  • issue_test/issue119_test.go
  • issue_test/issue123_test.go
  • issue_test/issue128_test.go
  • issue_test/issue138_test.go
  • issue_test/issue141_test.go
  • issue_test/issue144_test.go
  • issue_test/issue16_test.go
  • issue_test/issue182_test.go
  • issue_test/issue186_test.go
  • issue_test/issue195_test.go
  • issue_test/issue206_test.go
  • issue_test/issue213_test.go
  • issue_test/issue242_test.go
  • issue_test/issue248_test.go
  • issue_test/issue258_test.go
  • issue_test/issue263_test.go
  • issue_test/issue273_test.go
  • issue_test/issue27_test.go
  • issue_test/issue293_test.go
  • issue_test/issue39_test.go
  • issue_test/issue3_test.go
  • issue_test/issue45_test.go
  • issue_test/issue58_test.go
  • issue_test/issue5_test.go
  • issue_test/issue67_test.go
  • issue_test/issue76_test.go
  • issue_test/issue7_test.go
  • issue_test/issue82_test.go
  • issue_test/issue83_test.go
  • issue_test/issue8_test.go
  • issue_test/issue90_test.go
  • issue_test/issue93_test.go
  • issue_test/issue98_test.go
  • issue_test/issue_recurse_test.go
  • issue_test/plugin/main.go
  • issue_test/plugin_test.go
  • issue_test/pretouch_test.go
  • issue_test/testmain_test.go
  • loader/funcdata_go115.go
  • loader/funcdata_go116.go
  • loader/funcdata_go118.go
  • loader/funcdata_go120.go
  • loader/loader_go115.go
  • loader/loader_go116.go
  • loader/loader_go116_test.go
  • loader/loader_go117_test.go
  • loader/mmap_windows.go
  • option/option.go
  • search_test.go
  • sonic.go
  • testdata/small.go
  • unquote/unquote.go
  • use_number_test.go
  • utf8/utf8.go
  • utf8/utf8_test.go

github-actions[bot]
github-actions bot reviewed Feb 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 302 files.

Valid Invalid Ignored Fixed
6 203 93 0
Click to see the invalid file list
  • api.go
  • ast/api_amd64.go
  • ast/api_amd64_test.go
  • ast/api_compat.go
  • ast/decode.go
  • ast/encode.go
  • ast/encode_test.go
  • ast/error.go
  • ast/iterator.go
  • ast/iterator_test.go
  • ast/node.go
  • ast/node_test.go
  • ast/parser.go
  • ast/parser_test.go
  • ast/search.go
  • ast/search_test.go
  • ast/sort.go
  • ast/stubs_go115.go
  • ast/stubs_go120.go
  • ast/testdata_test.go
  • compat.go
  • compat_test.go
  • decode_float_test.go
  • decode_test.go
  • decoder/assembler_amd64_go116.go
  • decoder/assembler_amd64_go117.go
  • decoder/assembler_test.go
  • decoder/compiler.go
  • decoder/compiler_test.go
  • decoder/debug.go
  • decoder/decoder.go
  • decoder/decoder_test.go
  • decoder/errors.go
  • decoder/errors_test.go
  • decoder/generic_amd64_go116.go
  • decoder/generic_amd64_go117.go
  • decoder/generic_amd64_go117_test.s
  • decoder/generic_amd64_test.s
  • decoder/generic_test.go
  • decoder/norace_test.go
  • decoder/pools.go
  • decoder/primitives.go
  • decoder/stream.go
  • decoder/stream_test.go
  • decoder/stubs_go115.go
  • decoder/stubs_go120.go
  • decoder/testdata_test.go
  • decoder/types.go
  • decoder/utils.go
  • encode_test.go
  • encoder/assembler_amd64_go116.go
  • encoder/assembler_amd64_go117.go
  • encoder/assembler_test.go
  • encoder/compiler.go
  • encoder/compiler_test.go
  • encoder/debug_go116.go
  • encoder/debug_go117.go
  • encoder/encoder.go
  • encoder/encoder_test.go
  • encoder/errors.go
  • encoder/mapiter.go
  • encoder/pools.go
  • encoder/primitives.go
  • encoder/sort.go
  • encoder/sort_test.go
  • encoder/stream.go
  • encoder/stream_test.go
  • encoder/stubs_go116.go
  • encoder/stubs_go117.go
  • encoder/stubs_go120.go
  • encoder/testdata_test.go
  • encoder/types.go
  • encoder/utils.go
  • external_jsonlib_test/benchmark_test/decoder_stream_test.go
  • external_jsonlib_test/benchmark_test/decoder_test.go
  • external_jsonlib_test/benchmark_test/encoder_stream_test.go
  • external_jsonlib_test/benchmark_test/encoder_test.go
  • external_jsonlib_test/benchmark_test/parser_test.go
  • external_jsonlib_test/benchmark_test/search_test.go
  • external_jsonlib_test/benchmark_test/testdata_test.go
  • external_jsonlib_test/unit_test/api_test.go
  • external_jsonlib_test/unit_test/ast_compat_test.go
  • external_jsonlib_test/unit_test/decoder_stream_test.go
  • fuzz/ast_fuzz_test.go
  • fuzz/corpus.go
  • fuzz/fuzz_test.go
  • fuzz/other_fuzz_test.go
  • fuzz/struct_fuzz_test.go
  • generic_test/benchmark_test.go
  • generic_test/sonic_test.go
  • generic_test/testdata_test.go
  • internal/caching/fcache.go
  • internal/caching/hashing.go
  • internal/caching/hashing_test.go
  • internal/caching/pcache.go
  • internal/caching/pcache_test.go
  • internal/cpu/features.go
  • internal/jit/arch_amd64.go
  • internal/jit/assembler_amd64.go
  • internal/jit/backend.go
  • internal/jit/backend_test.go
  • internal/jit/runtime.go
  • internal/loader/funcdata.go
  • internal/loader/funcdata_go115.go
  • internal/loader/funcdata_go116.go
  • internal/loader/funcdata_go118.go
  • internal/loader/funcdata_go120.go
  • internal/loader/loader.go
  • internal/loader/loader_go117_test.go
  • internal/loader/loader_test.go
  • internal/loader/loader_windows.go
  • internal/native/avx/fastfloat_amd64_test.go
  • internal/native/avx/fastint_amd64_test.go
  • internal/native/avx/native_amd64.go
  • internal/native/avx/native_amd64_test.go
  • internal/native/avx/native_export_amd64.go
  • internal/native/avx2/fastfloat_amd64_test.go
  • internal/native/avx2/fastint_amd64_test.go
  • internal/native/avx2/native_amd64.go
  • internal/native/avx2/native_amd64_test.go
  • internal/native/avx2/native_export_amd64.go
  • internal/native/dispatch_amd64.go
  • internal/native/dispatch_amd64.s
  • internal/native/sse/fastfloat_amd64_test.go
  • internal/native/sse/fastint_amd64_test.go
  • internal/native/sse/native_amd64.go
  • internal/native/sse/native_amd64.s
  • internal/native/sse/native_amd64_test.go
  • internal/native/sse/native_export_amd64.go
  • internal/native/sse/native_subr_amd64.go
  • internal/native/types/types.go
  • internal/resolver/resolver.go
  • internal/resolver/resolver_test.go
  • internal/resolver/stubs.go
  • internal/rt/asm_amd64.s
  • internal/rt/asm_arm64.s
  • internal/rt/fastmem.go
  • internal/rt/fastvalue.go
  • internal/rt/gcwb.go
  • internal/rt/int48.go
  • issue_test/hugestruct_test.go
  • issue_test/issue100_test.go
  • issue_test/issue101_test.go
  • issue_test/issue107_test.go
  • issue_test/issue108_test.go
  • issue_test/issue112_test.go
  • issue_test/issue113_test.go
  • issue_test/issue115_test.go
  • issue_test/issue119_test.go
  • issue_test/issue123_test.go
  • issue_test/issue128_test.go
  • issue_test/issue138_test.go
  • issue_test/issue141_test.go
  • issue_test/issue144_test.go
  • issue_test/issue16_test.go
  • issue_test/issue182_test.go
  • issue_test/issue186_test.go
  • issue_test/issue195_test.go
  • issue_test/issue206_test.go
  • issue_test/issue213_test.go
  • issue_test/issue242_test.go
  • issue_test/issue248_test.go
  • issue_test/issue258_test.go
  • issue_test/issue263_test.go
  • issue_test/issue273_test.go
  • issue_test/issue27_test.go
  • issue_test/issue293_test.go
  • issue_test/issue39_test.go
  • issue_test/issue3_test.go
  • issue_test/issue45_test.go
  • issue_test/issue58_test.go
  • issue_test/issue5_test.go
  • issue_test/issue67_test.go
  • issue_test/issue76_test.go
  • issue_test/issue7_test.go
  • issue_test/issue82_test.go
  • issue_test/issue83_test.go
  • issue_test/issue8_test.go
  • issue_test/issue90_test.go
  • issue_test/issue93_test.go
  • issue_test/issue98_test.go
  • issue_test/issue_recurse_test.go
  • issue_test/plugin/main.go
  • issue_test/plugin_test.go
  • issue_test/pretouch_test.go
  • issue_test/testmain_test.go
  • loader/funcdata_go115.go
  • loader/funcdata_go116.go
  • loader/funcdata_go118.go
  • loader/funcdata_go120.go
  • loader/loader_go115.go
  • loader/loader_go116.go
  • loader/loader_go116_test.go
  • loader/loader_go117_test.go
  • loader/mmap_windows.go
  • option/option.go
  • search_test.go
  • sonic.go
  • testdata/small.go
  • unquote/unquote.go
  • use_number_test.go
  • utf8/utf8.go
  • utf8/utf8_test.go

@AsterDY AsterDY force-pushed the bugfix/omit_checkptr branch from 31e0ac9 to 12f7f69 Compare February 28, 2023 07:11
@AsterDY AsterDY merged commit 6d60889 into main Feb 28, 2023
@AsterDY AsterDY deleted the bugfix/omit_checkptr branch February 28, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@liuq19 liuq19 liuq19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsterDY @liuq19