Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unmarshal into defined ptr type #392

Merged
merged 3 commits into from
Apr 3, 2023
Merged

fix: unmarshal into defined ptr type #392

merged 3 commits into from
Apr 3, 2023

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Mar 23, 2023 •
edited
Loading

Try to fix #379.

  1. Deal with the defined pointer type (elem with marshaler methods) as encoding/json.
  2. Not inline when compiling the pointer.

AsterDY
AsterDY reviewed Mar 27, 2023
View reviewed changes
decoder/compiler.go Outdated Show resolved Hide resolved
AsterDY
AsterDY previously approved these changes Mar 28, 2023
View reviewed changes
@liuq19 liuq19 enabled auto-merge (squash) March 28, 2023 05:39
@liuq19 liuq19 merged commit 7e82ad0 into bytedance:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsterDY AsterDY AsterDY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnmarshalJSON死循环
2 participants
@liuq19 @AsterDY