fix(arm): grow slice not clear mem #674
Conversation
| new := GrowSlice(et, *old, newLen) | ||
|
|
||
| // we sould clear the memory from [oldLen:newLen] | ||
| if et.PtrData == 0 { |
There was a problem hiding this comment.
为啥noscan需要清理？scan类型不需要清理？？
There was a problem hiding this comment.
是的，因为runtime.growslice 对于 [oldlen, newlen) 这段区间的的非指针数据是不需要清空的
There was a problem hiding this comment.
因为 makeslice 里面长度会变成 newLen, 而且如果遇到非匹配类型，会跳过这些类型。因此需要清空
There was a problem hiding this comment.
因为makeslice 的语义其实是需要初始化所有元素的，因为如果decode 遇到不需要解析的类型会直接skip，不初始化可能会有脏数据
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 52.85% 52.63% -0.23%
==========================================
Files 174 142 -32
Lines 11470 11397 -73
==========================================
- Hits 6063 5999 -64
+ Misses 5071 5068 -3
+ Partials 336 330 -6 ☔ View full report in Codecov by Sentry. |
No description provided.