Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Spinnaker to version 2.4.0.143 #1040

Merged
merged 13 commits into from
May 9, 2021

Conversation

jpsacha
Copy link
Member

@jpsacha jpsacha commented May 5, 2021

No description provided.

@jpsacha
Copy link
Member Author

jpsacha commented May 5, 2021

CI Test are failing, but it looks that the old version of the links for binaries are code is used. It is downloading old version of binaries 1.27.0.48 using old links. For instance see https://github.com/bytedeco/javacpp-presets/pull/1040/checks?check_run_id=2505944194#step:2:283
That link is not present in the committed code. Is this some code from cache?

@saudet
Copy link
Member

saudet commented May 5, 2021

No, it's the location of the actions used in the workflow that is causing this:
https://github.com/bytedeco/javacpp-presets/blob/master/.github/workflows/spinnaker.yml
You can temporarily change those to this branch on your fork to this test the update.

@jpsacha
Copy link
Member Author

jpsacha commented May 5, 2021

I do not see any reference to specific branches in https://github.com/bytedeco/javacpp-presets/blob/master/.github/workflows/spinnaker.yml
It is not clear to me how downloads are going from a different branch than tested. May be some other some other file has them hardcoded?

By the way, Spinnaker dropped support for Ubuntu 16.04 (as it lost its LTS status this month), so that will need to be updated to 18.04 or 20.04. Spinnaker binaries used in CI are for 18.04 (20.04 are available too). I can update that separately. 16.04 dropping from LST will impact other tests, beside Spinnaker, too.

@saudet
Copy link
Member

saudet commented May 6, 2021

I do not see any reference to specific branches in https://github.com/bytedeco/javacpp-presets/blob/master/.github/workflows/spinnaker.yml
It is not clear to me how downloads are going from a different branch than tested. May be some other some other file has them hardcoded?

Simply replace bytedeco/javacpp-presets with jpsacha/javacpp-presets and @actions with @Spinnaker_2.4.0.143.

By the way, Spinnaker dropped support for Ubuntu 16.04 (as it lost its LTS status this month), so that will need to be updated to 18.04 or 20.04. Spinnaker binaries used in CI are for 18.04 (20.04 are available too). I can update that separately. 16.04 dropping from LST will impact other tests, beside Spinnaker, too.

It's still getting built from CentOS 6, and it's working fine, so I wouldn't worry about that.

@saudet
Copy link
Member

saudet commented May 6, 2021

BTW, for debugging purposes, we can connect via SSH to the build machines with, for example, this action:
https://github.com/marketplace/actions/debugging-with-tmate

@jpsacha
Copy link
Member Author

jpsacha commented May 7, 2021

All set now. CI build are passing. Enjoying new faster CI setup 👍

@saudet saudet merged commit a4c403f into bytedeco:master May 9, 2021
@jpsacha jpsacha deleted the Spinnaker_2.4.0.143 branch May 20, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants