-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade LLVM preset to 12.0.1 #1065
Conversation
I had to fix a couple of things there actually. Could you rebase on master and try again? |
Arrow builds are working again. Still getting that linker error with TVM. It also fails to build 12.0.0, so it's probably not a regression. |
TVM builds fine on GitHub Actions, so I guess it's OK. Let's just update it! BTW, instead of a separate job, let's try to get those examples running as part of the build of each platform, so they can succeed even from pull requests like this. |
Okay, I will look into this. |
The samples can run in CI by running it in the same job on the next stage. Got this working on a forked branch here https://github.com/supergrecko/javacpp-presets/blob/run-samples-in-ci/.github/workflows/llvm.yml#L42 My only concern is that the config will become huge if more samples are added like this (e.g. clang ones). Maybe we could think about integrating a sample execution step into the .github/actions scripts? |
My thinking here is that we should be able to use a Maven Plugin like Surefire, Failsafe, or Invoker, such that everything ends up in the pom.xml files somewhere instead of GitHub Actions, probably something like a mix of how JavaCPP and JavaCV do it: |
The LLVM 12.0.1 release adds Type metadata (https://reviews.llvm.org/D97763) to the LLVM-C API
I had troubles building TVM and Arrow using 12.0.1 locally so those presets have not been updated. It would be great if you could take a closer look at those.
-force_load
. I did some googling and it looks like it's an Xcode option. I'm not on macOS, so this sounds like a build system error.Let me know if you need more information to investigate. I'm building with Clang-10.0.0-4ubuntu1 and GCC/g++ 9.3.0 using LLD 10.0.0