Synchronize and prevent repeated package caching in all presets #1071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I suggest to store
pythonFile
computed in thecpython.presets.python.cachePackage()
in a static variable and to return it if it is already computed to prevent caching of the python packages multiple times.I assume the result should be the same in each call?
This method is called twice when using the embeddedpython.Python class (in a stripped variant) and each call takes at least one third of the 2 seconds initialization time of
embeddedpython.Python
. So also caching the path would speed up the initialization significantly.Actually this method could be synchronized to prevent concurrent caching of the packages. If you agree I can update this PR accordingly.