-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add presets for LZ4 #1094
Add presets for LZ4 #1094
Conversation
Out of curiosity, what's missing from https://github.com/lz4/lz4-java? |
https://github.com/lz4/lz4-java does not support the LZ4 Frame Format sufficiently.
The goal is to use these presets for the Java implementation of Apache Arrow. Currently, Apache Commons Compress is used because of the limitations with lz4-java and the Frame format. However, this is very slow. |
Also update CHANGELOG.md, README.md and pom.xml files
Thank you for the fixes and for merging this so quickly! |
Well, please try with the snapshots first, and if there's nothing to fix,
we can make an initial release at that point!
|
Hi @saudet, trying the snapshots first was a good suggestion. We discovered problems on Mac OS:
It seems like the |
Right, I always forget. The rpath is never set correctly on Mac. We can hack it after the build with install_name_tool this way: https://github.com/bytedeco/javacpp-presets/blob/master/mxnet/cppbuild.sh#L213 |
Awesome. Does not look too hard. I will take a look. Thank you! |
This PR adds presets for very fast compression and decompression with lz4.
The presets are currently enabled for Linux, Mac OS, and Windows on x86 and x86_64. It is probably possible to enable them on other platforms, but I haven't had time to look into it yet.
The GitHub Action for Windows is failing, and I neither have a Windows system nor enough experience with C/C++ compilers and linking to fix it. @chaubold started looking into it, but any help from someone experienced with JavaCPP presets would be welcome.