Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to ffmpeg 5.0 #1125

Merged
merged 5 commits into from
Jan 18, 2022
Merged

update to ffmpeg 5.0 #1125

merged 5 commits into from
Jan 18, 2022

Conversation

bradh
Copy link
Contributor

@bradh bradh commented Jan 15, 2022

No description provided.

@saudet
Copy link
Member

saudet commented Jan 16, 2022

It looks like autoreconf is broken in the new Windows image of GitHub Actions.
Since the only thing using that is libmfx, let's move it to CMake...

ffmpeg/README.md Outdated
@@ -1,36 +1,38 @@
# JavaCPP Presets for FFmpeg
JavaCPP Presets for FFmpeg
==========================
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would ask that these markdown changes not be reverted. They show up as red squiggle errors in my editor (i.e. fail markdown linting).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no reason to make it inconsistent with the other README.md files. If there's a good reason to change it though, we'll do it for all of them, and that's going to be for another pull request if you want to do that. However, maybe it's just your linting tool that's buggy. How do you know that's not the case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's do that in different commits, for the other repositories too!

BTW, it doesn't appear to violate setext_with_atx, that looks alright. The reason I do it that way is that it looks better with setext, but there aren't any for level 3. I guess I'm not the only one to feel that way.

@saudet
Copy link
Member

saudet commented Jan 17, 2022

So, this looks good to merge? We can work on the markdown and issue #1099 later and open more pull requests for that.

@bradh bradh marked this pull request as ready for review January 17, 2022 10:21
@saudet saudet merged commit aca1529 into bytedeco:master Jan 18, 2022
@bradh bradh deleted the ffmpeg5 branch January 18, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants