Introduce linux-arm64 to presets for libpostal
#1199
Conversation
MasseGuillaume
force-pushed
the
libpostal-linux-arm64
branch
2 times, most recently
from
57c7e35
to
be1fa26
Compare
|
Looks good, but please fix the builds on GitHub Actions! Also, there's a couple of missing entries in platform/pom.xml. |
MasseGuillaume
force-pushed
the
libpostal-linux-arm64
branch
from
be1fa26
to
aff6294
Compare
|
Hi, sorry for the delay I was on vacation. It looks like the failure was related to some changes in GitHub unrelated to this PR: Downloading https://github.com/openvenues/libpostal/archive/v1.1.tar.gz gives the following error:
I fixed the URL by adding refs tags to remove the ambiguity. I will need your approval to re-run the Github actions. |
|
https://github.com/openvenues/libpostal/archive/refs/tags/v1.1.tar.gz seems to be working correctly. Let's use that? |
|
Yup that's the fix I'm trying right now. |
MasseGuillaume
force-pushed
the
libpostal-linux-arm64
branch
from
aff6294
to
00d4297
Compare
|
Hum something is off I think it might be related to the missing 00d4297#diff-95113202bf744a6965dfbcb1a37d7690d52ae6258cabed7bb1e5245921450e63 |
|
I will need your approval once again to run the workflow. |
No, that's alright. GitHub Actions doesn't have ARM runners, yet, so we need to cross compile. |
MasseGuillaume
force-pushed
the
libpostal-linux-arm64
branch
from
00d4297
to
60aba1e
Compare
|
Ah ok I understand now, I added the cross-compilation flag: If you can allow the CI to run, I think this time it should work. |
|
Great, it looks like we now have a linux-arm64 libpostal: https://github.com/MasseGuillaume/javacpp-presets/runs/7520138130 |
|
I think this PR is all good for a merge, did I miss anything? |
No description provided.