libffi: hide platform-ignorant FFI ABI enum values #1318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ignores processing the whole
ffitarget.h
file, which If i understood correctly contains platform-specific values, but only for one platform, and therefore is on most platforms wrong. I believe the platform-specific values can already be accessednative
methods handwritten in the preset. I added the otherwise missingFFI_TRAMPOLINE_SIZE()
method.I think only two other variables remain in the
ffitarget.h
file, which areFFI_CLOSURES = 1; FFI_GO_CLOSURES = 1;
. I'm not super sure, but i believe those are only there to enable/disable definitions in the other header, it shouldn't hurt not to have them.I tried
mvn clean test --projects .,libffi
and it succeeds. I have not figured out if there are more tests to run?See #1315