Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address OpenCV fisheye symbol collision #1324

Merged
merged 3 commits into from
Feb 18, 2023
Merged

Address OpenCV fisheye symbol collision #1324

merged 3 commits into from
Feb 18, 2023

Conversation

ds58
Copy link
Contributor

@ds58 ds58 commented Feb 15, 2023

This PR should address #1185

OpenCV has cv:::initUndistortRectifyMap and cv::fisheye::initUndistortRectifyMap in the calib3d module. The Java for the fisheye version wasn't getting generated because of the symbol collision. I added a javaNames for the fisheye version so it maps to fisheyeInitUndistortRectifyMap

@saudet
Copy link
Member

saudet commented Feb 16, 2023

Looks good, thanks! While we're it, let's also prefix with "fisheye" all functions from thecv::fisheye namespace?
If I'm not overlooking anything, the complete list is:
cv::fisheye::projectPoints
cv::fisheye::distortPoints
cv::fisheye::undistortPoints
cv::fisheye::initUndistortRectifyMap
cv::fisheye::undistortImage
cv::fisheye::estimateNewCameraMatrixForUndistortRectify
cv::fisheye::calibrate
cv::fisheye::stereoRectify
cv::fisheye::stereoCalibrate

@ds58
Copy link
Contributor Author

ds58 commented Feb 16, 2023

While we're it, let's also prefix with "fisheye" all functions from thecv::fisheye namespace?

Yes, I think that's a good idea. I've done that.

@saudet saudet merged commit 087d4a4 into bytedeco:master Feb 18, 2023
@ds58 ds58 deleted the opencv-fisheye-mapping branch June 1, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants