-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add higher level tritonserver API #1361
Add higher level tritonserver API #1361
Conversation
…-wrapper-to-build
3642456
to
b904fbb
Compare
Thanks! Instead of adding a new module though, I think we could simply update the original tritonserver one with the new "tritonserverwrapper"? BTW, we typically name these presets after the library names, which is in this case "tritondevelopertoolsserver"... |
|
It makes it harder to maintain and for users to use as well. Let's please
not do that. I'm not going to maintain them in that form myself and they
are currently not functional because they are missing too many
configurations.
How about this, if you're not going to maintain the C interface, let's nuke
it?
|
3b4f6b0
to
e90149b
Compare
Updated the PR. I noticed there's some issues caused by updating the tritonserver.h from 23.04 to 23.05 though comparison link. Through this PR: triton-inference-server/core#192 we made tritonserver.h conform to proper C standard (vs C++ standard). tritonserver.java created seemed to be confused and ommited a few functions that used defined variables.: 63431c6#diff-0b23a69d7a0bd76ec9fff99224228855a84574ccaf9185df0c5d774ba00dc933 I tried to use cpptext and it also did not solve the problem locally. Is there anything else I should be doing? I checked, and 23.04 seems to be compiling fine. |
Right now it's not failing because of that, but because of this:
Let's start by fixing this |
I've fixed the parser issue with function pointers in commit bytedeco/javacpp@b9f91d7 so it should work fine now. |
@saudet Thanks for your help! It looks like samples/Simple.java is running fine but the example for samples/SimpleCPP.java does not work. Is this something with how platform/pom.xml is written? |
What do you mean by does not work? What's the error message that you get? |
It simply does not find the C++ binding files. I checked in the compiled jar and it seems like all the generated java files are in there |
Could you run the sample with |
ca9273c
to
c29cae0
Compare
c29cae0
to
b02482d
Compare
I think I found the reason of the failure. Thanks. Let me know if there's anything else that needs to be changed |
tritonserver/src/main/java/org/bytedeco/tritonserver/presets/tritonserver.java
Outdated
Show resolved
Hide resolved
@saudet I've addressed the comments. Anything else to do before merging to master? |
Looks good! Thanks |
With https://github.com/triton-inference-server/developer_tools/tree/main/server,
Triton added a C++ API that is higher level API for the original API.
This PR adds
tritonserverwrapper
project that makes use of that API. It is higher than theJavacpp/tritonserverwrapper project