-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pytorch, OpenCV] Implicit ArrayRef, Updates for JavaCPP 1.5.10 #1455
Conversation
Is this pull request done? You're not going to add anything more here for other presets? |
Done |
Please don't push 200 times a day, Google Drive really doesn't like it, and I don't know how to fix this |
I haven't pushed anything for 3 days. Can I help somehow ? |
Start by not pushing more than once a day the next time. Why do you do that
anyway?
|
According to the log above, there was just 3 pushes the same day, 4 days ago. No particular reason. I just worked this whole day on the PR I guess. |
I asked you why do you had to push more than once a day, and you basically answered that you don't need to. So, don't push more than once a day! Ok? Whenever you push something, the builds for everything that you touched get triggered. Don't do that. Maybe I should just disable automatic triggers for pull request if that feature exists (it doesn't seem to exist), but jeez, just don't push more than once a day! Just don't do it |
@HGuillemet The SimpleMNIST sample code doesn't work anymore after merging this. Please fix it
|
This is the issue about Stack mentioned in bytedeco/javacpp#733. I'll add an ugly It could be nice to be able in Info to specify an arbitrary javaText to be appended to a class without having to give the text of the whole class or to hook to another existing, unrelated, declaration in the class. Shall I push the commit to this PR even if it has already been merged ? or open another ? |
We can just replace the constructor, no?
Yeah, I thought I did that somewhere already, but I guess not. It's not obvious how it would work. We'd probably need to add new flags and what not, so unless we figure out a nice way to do it without that, let's not do that
Another pull request please, but I'm pretty much done with the release I think, so if no one complained until now I guess no one needs it, so we can do that later I suppose, sounds good? |
Well, in fact I don't know how to replace the whole class text. If I add a javaText to the type, it's copied elsewhere when the type is used, not only in the class definition.
The constructor is generated here.
As you wish. No idea if ExampleStack and TensorExampleStack is of common use. I don't use the dataset api myself. |
No, I'm not going to wait after you fixing things endlessly. You keep breaking things, so if someone complains, please fix it. Otherwise, it's not important I suppose. |
Pytorch
ArrayRef
accept also aVector
(relying on C++ converting constructor ofArrayRef
) when the corresponding vector template instance has been mapped in Java. This allows to write for instance:TensorArrayRef
to pass toindex
. This is still much heavier that what we can write in C++:Tensor tensor2 = tensor1.index({x, Slice()});
ArrayRef
.OpenCV
Info.upcast()
onAlgorithm
to prevent crashes when upcasting or downcastingcv::read
andcv::write