Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinnaker: update to 4.0.0.116 #1524

Merged
merged 11 commits into from
Aug 9, 2024
Merged

Conversation

jpsacha
Copy link
Member

@jpsacha jpsacha commented Aug 3, 2024

Note: 4.0.0.116 dropped support for windows-x86

Note: 4.0.0.116 dropped support for windows-x86
@saudet
Copy link
Member

saudet commented Aug 3, 2024

Looks like the new module name for the CLI of gdown is gdown, so please try to replace gdown.cli with gdown

@jpsacha
Copy link
Member Author

jpsacha commented Aug 3, 2024

Something is wrong here. The workflow executed is not what is in the PR. It is still running Spinnaker 3 setup:
https://github.com/bytedeco/javacpp-presets/actions/runs/10225285866/job/28294117320?pr=1524#step:2:275

@saudet
Copy link
Member

saudet commented Aug 3, 2024

Right, we need to change temporarily the actions in the workflow when we do that

@jpsacha
Copy link
Member Author

jpsacha commented Aug 4, 2024

Looks that is working now

@saudet saudet merged commit 88c4276 into bytedeco:master Aug 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants