Enable HDF5 build on aarch64 machine #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional platform check handling for linux-arm64 machines to account for aarch64 as a possible machine type. New code for the `"$MACHINE_TYPE" =~ aarch64` case executes same commands for arm64 machine type, but omitting `-m64` flags from g++ and gcc as they are unnecessary and throw errors on aarch64.
saudet
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional platform check handling in
cppbuild.shfor linux-arm64 machines to account for aarch64 as a possible machine type.New code for the
"$MACHINE_TYPE" =~ aarch64case executes same commands for arm64 machine type, but omitting-m64flags from g++ and gcc as they are unnecessary and throw errors on aarch64.