-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build MXNet under windows #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I will try it out!
One thing though, it doesn't work for windows-x86. Either please provide a build or change "windows-*" and "windows" to "windows-x86_64". Thank you!
A few other things:
Then the native library builds, but "Nothing generated for C:\msys64\tmp\javacpp-presets\mxnet\target\classes\org\bytedeco\javacpp\jnimxnet.cpp". If I use the original presets then "LINK : fatal error LNK1181: cannot open input file 'mxnet.lib'", so there's still a bit to clean up, but once that's done, it looks like it's going to work, so it should be good to merge! Thanks |
I will have a look at it tomorrow. Downloading archives from the master branch might not be a good idea. Sometime MXNet is not stable, whats why I added the the stable commit part. They plan to release a new version 0.9 which we could use later on. Until then it might be better to git clone a stable commit for all operating systems. |
Sure, please download those for other platforms as well, but do not use git: It doesn't always work well on Windows. |
FYI, it's possible to download a specific commit if that was your question, for example: |
FYI, I made some changes on the master branch that conflicts with your fork, so make sure to update it and resolve them! |
…able platforms and work with any build system (sbt, Gradle, M2Eclipse, etc)
…um_threads()` and `blas_get_vendor()` functions
There should not be any conflicts. Github is blaming openblas.java because I've changed line 40 by adding "link = "libopenblas"," while you have changed line 39 to include the new blas_extrax.h |
You could just reset and rebase your fork, that'll clear out everything for sure :) |
How do I reset a pull request? If I delete my remote fork Neiko2002/javacpp-presets nothing will happen to this pull request. I could not find any help here either: |
Something like this: https://help.github.com/articles/syncing-a-fork/ |
When I do all of this, I have a local branch with your changes first, followed by the changes of this PR. But my remote master javacpp-presets is still the same. I can not reverse the changes of the remote master and therefore not the changes in this PR. I've pushed the rebased and updated local branch to another remote branch: |
It's always possible to do |
|
Hi, any news on this? The presets are now officially upgraded to Visual Studio 2015 as per #298, so this should go a lot more smoothly now. It would be great to have a build of MXNet for Windows! In any case, I think it would be easiest to start a new PR from scratch. GitHub will probably do that anyway if we try to reset the branch. Thanks for everything and let me know if you run into issues again. Thanks! |
a1fa858
to
22f9ebd
Compare
Several fixes for the new javacpp-preset version 1.2.5. Many of them have been discussed here:
#298
Additionally there is Windows support for MXNet.