Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build MXNet under windows #309

Merged
merged 18 commits into from
Oct 2, 2018
Merged

Build MXNet under windows #309

merged 18 commits into from
Oct 2, 2018

Conversation

Neiko2002
Copy link
Member

Several fixes for the new javacpp-preset version 1.2.5. Many of them have been discussed here:
#298

Additionally there is Windows support for MXNet.

Copy link
Member

@saudet saudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will try it out!

One thing though, it doesn't work for windows-x86. Either please provide a build or change "windows-*" and "windows" to "windows-x86_64". Thank you!

@saudet
Copy link
Member

saudet commented Oct 26, 2016

A few other things:

  1. Please get rid of the tabs and use spaces instead
  2. There is a return 0 that prevents the build from actually proceeding in cppbuild.sh
  3. Could you use the files as downloaded in the downloads directory, the same as for the other platforms?

Then the native library builds, but "Nothing generated for C:\msys64\tmp\javacpp-presets\mxnet\target\classes\org\bytedeco\javacpp\jnimxnet.cpp". If I use the original presets then "LINK : fatal error LNK1181: cannot open input file 'mxnet.lib'", so there's still a bit to clean up, but once that's done, it looks like it's going to work, so it should be good to merge! Thanks

@Neiko2002
Copy link
Member Author

I will have a look at it tomorrow. Downloading archives from the master branch might not be a good idea. Sometime MXNet is not stable, whats why I added the the stable commit part. They plan to release a new version 0.9 which we could use later on. Until then it might be better to git clone a stable commit for all operating systems.

@saudet
Copy link
Member

saudet commented Oct 26, 2016

Sure, please download those for other platforms as well, but do not use git: It doesn't always work well on Windows.

@saudet
Copy link
Member

saudet commented Oct 28, 2016

FYI, it's possible to download a specific commit if that was your question, for example:
https://github.com/dmlc/mxnet/archive/a5aeb0c43028f41863a8148eb3ecf30e90caad1e.tar.gz

@saudet
Copy link
Member

saudet commented Oct 29, 2016

FYI, I made some changes on the master branch that conflicts with your fork, so make sure to update it and resolve them!

@Neiko2002
Copy link
Member Author

There should not be any conflicts. Github is blaming openblas.java because I've changed line 40 by adding "link = "libopenblas"," while you have changed line 39 to include the new blas_extrax.h

@saudet
Copy link
Member

saudet commented Oct 31, 2016

You could just reset and rebase your fork, that'll clear out everything for sure :)

@Neiko2002
Copy link
Member Author

How do I reset a pull request? If I delete my remote fork Neiko2002/javacpp-presets nothing will happen to this pull request.

I could not find any help here either:
https://help.github.com/categories/collaborating-with-issues-and-pull-requests/

@saudet
Copy link
Member

saudet commented Nov 1, 2016

Something like this: https://help.github.com/articles/syncing-a-fork/
But after fetching the upstream repo, we can also reset and rebase instead of merge...

@Neiko2002
Copy link
Member Author

When I do all of this, I have a local branch with your changes first, followed by the changes of this PR. But my remote master javacpp-presets is still the same. I can not reverse the changes of the remote master and therefore not the changes in this PR.

I've pushed the rebased and updated local branch to another remote branch:
https://github.com/Neiko2002/javacpp-presets/tree/mxnet

@saudet
Copy link
Member

saudet commented Nov 1, 2016

It's always possible to do git reset to whatever commit we wish.

@saudet
Copy link
Member

saudet commented Nov 5, 2016

git merge should work fine as well. Anyway, feel free to create another pull request if you prefer.

@saudet
Copy link
Member

saudet commented Apr 8, 2017

Hi, any news on this? The presets are now officially upgraded to Visual Studio 2015 as per #298, so this should go a lot more smoothly now. It would be great to have a build of MXNet for Windows!

In any case, I think it would be easiest to start a new PR from scratch. GitHub will probably do that anyway if we try to reset the branch.

Thanks for everything and let me know if you run into issues again. Thanks!

@saudet saudet removed the help wanted label Oct 2, 2018
@saudet saudet merged commit 99b82ac into bytedeco:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants