Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LiquidFun presets #356

Merged
merged 6 commits into from
Mar 4, 2017
Merged

Add LiquidFun presets #356

merged 6 commits into from
Mar 4, 2017

Conversation

floybix
Copy link
Contributor

@floybix floybix commented Jan 12, 2017

Hey,

Thanks for making this amazing tool. I've put together a preset for LiquidFun, a 2D physics library. (incidentally, this is now a more complete replacement for the pure-java porting effort https://github.com/jbox2d/jbox2d )

The latest release is missing some stuff so I actually referred to a github commit... seems pretty stable though; their last commit was nearly 2 years ago.

I only have a mac, so just added support for that platform so far.

@saudet
Copy link
Member

saudet commented Jan 29, 2017

Thanks for your contribution! Sorry for being a bit slow in checking this out. I've pushed support for Linux x86 and x84_64. Seems to work fine. :) Now, what should we do about the version? 1.1.0 is pretty old... For other libraries like that that don't maintain versions, instead of trying to change our version based on every commit in their master branch, I just use the version of the JavaCPP Presets + "master" as version. What do you think?

@floybix
Copy link
Contributor Author

floybix commented Jan 30, 2017 via email

@saudet
Copy link
Member

saudet commented Feb 4, 2017

It looks like the accepted convention is a mix of both, for example:
https://ffmpeg.zeranoe.com/builds/
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshot_packages

@floybix
Copy link
Contributor Author

floybix commented Feb 4, 2017 via email

@saudet
Copy link
Member

saudet commented Feb 4, 2017

Yes, yyyymmdd-hash sounds like the right thing to do. Please make the changes! Thanks

@floybix
Copy link
Contributor Author

floybix commented Feb 13, 2017

Done; let me know if there's anything else to do.

@saudet
Copy link
Member

saudet commented Mar 4, 2017

I added a couple of things missing, but looks good! Thanks

@saudet saudet merged commit fbebb1c into bytedeco:master Mar 4, 2017
@saudet saudet mentioned this pull request May 14, 2017
@saudet
Copy link
Member

saudet commented May 28, 2017

FYI, thanks to @vb216, SNAPSHOT artifacts are now available here:
https://oss.sonatype.org/content/repositories/snapshots/org/bytedeco/javacpp-presets/liquidfun/
Let us know if you have any issues with them and thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants