Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for FlyCapture v.2.10.3.266. #400

Merged
merged 2 commits into from
Apr 1, 2017

Conversation

jpsacha
Copy link
Member

@jpsacha jpsacha commented Mar 24, 2017

No description provided.

@saudet
Copy link
Member

saudet commented Mar 24, 2017

Thanks! The problem with that though is they dropped support for PGRFlyCapture, which FlyCaptureFrameGrabber depends on:
https://github.com/bytedeco/javacv/blob/master/src/main/java/org/bytedeco/javacv/FlyCaptureFrameGrabber.java
There is also FlyCapture2FrameGrabber, but does it work just as well as FlyCaptureFrameGrabber?
https://github.com/bytedeco/javacv/blob/master/src/main/java/org/bytedeco/javacv/FlyCapture2FrameGrabber.java
I do not currently have access to a FlyCapture camera, so I cannot test this myself at the moment...

@jpsacha
Copy link
Member Author

jpsacha commented Mar 25, 2017

Do we need two of them? Do you know if there is there something unique in FlyCaptureFrameGrabber that should be ported to FlyCapture2FrameGrabber?

I will try to test FlyCapture2FrameGrabber with 2.10.3.266.

@saudet
Copy link
Member

saudet commented Mar 25, 2017

We don't need 2 of them, but I'm under the impression that FlyCapture2FrameGrabber is missing some things. @poqudrof ?

@jpsacha
Copy link
Member Author

jpsacha commented Mar 28, 2017

I tested FlyCapture2FrameGrabber it worked fine with 2.10.3.266 (first without modifications).
I also made changes to FlyCapture2FrameGrabber to make it similar to FlyCaptureFrameGrabber, see
javacv PR #655

@saudet saudet merged commit 5033390 into bytedeco:master Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants