ONNX (v1.2.2) preset

[EmergentOrder]

No description provided.

[saudet]

Looking good, thanks! Could you also do the following though?

1. Add an entry for at least linux-x86_64 to .travis.yml
2. Move the lines about installing miniconda to install-travis.sh in the ci subdirectory
3. Make a patch file out of schema.h instead of including the whole file

And let's see what Travis CI has to say about that before we can merge! Thanks

[EmergentOrder]

Done!
Thanks for the help along the way

[EmergentOrder]

@saudet Just when I think I finally have these build issues fixed, something new pops up.
Specifically,

[ERROR] /javacpp-presets/onnx/src/main/java/org/bytedeco/javacpp/onnx.java:[1187,16] repeated annotations are not supported in -source {0}
[ERROR] (use -source 8 or higher to enable repeated annotations)
[ERROR] /javacpp-presets/onnx/src/main/java/org/bytedeco/javacpp/onnx.java:[1189,16] org.bytedeco.javacpp.annotation.StdString is not a repeatable annotation type

This is happening today for the first time, only with JavaCPP 1.4.2-SNAPSHOT. When I point to 1.4.1, no compile error (locally).
I can log an issue, but I thought I'd just give you the heads up first (as I think this will fail my next CI build here)

[saudet]

Oops, sorry about, fixed: bytedeco/javacpp@be49bde

BTW, installing miniconda on the host with apt-get probably won't work. The builds happen in Docker containers.

Also, FYI, for faster turnaround with CI we can temporarily disable all other builds in .travis.yml and .appveyor.yml.

[EmergentOrder]

Yeah, the build was taking forever, thanks for the suggestion, I disabled the other projects.
Also, I actually don't think I need apt-get or anything at all in install-travis.sh now.
There are a lot of commits here now, from tangling with the CI. If you want, I can put this all in a single commit (once it passes) to clean up the history.

[saudet]

We can "squash" the commits when merging with GitHub, so don't worry about that.

[EmergentOrder]

@saudet ok, I got past the default_instance declaration errors by skipping. I still get these 2 errors though:

javacpp-presets/onnx/target/classes/org/bytedeco/javacpp/jnionnx.cpp:1452:51: error: expression cannot be used as a function
         StringAdapter radapter(ptr->string_value_());

and

javacpp-presets/onnx/target/classes/org/bytedeco/javacpp/jnionnx.cpp:1487:46: error: expression cannot be used as a function
         rptr = ptr->string_value_((char*)ptr0);```

[EmergentOrder]

once again, it looks like skip did the trick. I'll push my changes now

[EmergentOrder]

@saudet should be good to go

[saudet]

Thanks! Looks like ONNX 1.2.2 is out. Could we update the presets?

[saudet]

Would you also have some sample code we could put in a README.md file?

[EmergentOrder]

I had a branch with 1.1.0 ready to go, looks like I can bump that to 1.1.2 without issue. I'll push the merged changes from that now.
1.2.2 has errors, so I'll look at those at some point when I have a moment.

[EmergentOrder]

1.2.2 builds now but throws a runtime error in my first test with the jar

[EmergentOrder]

looks like an issue with an rvalue reference that was introduced

[saudet]

Can't really use those usually. Make sure it doesn't get called.

[saudet]

BTW, could you add a README.md file with your sample code in it?

[saudet]

I've been fixing and cleaning this up, and now it looks good to merge! I've also changed the license to match the other presets, so please let me know if this not OK with you. Thanks!

[EmergentOrder]

Thanks for that, it looks good at a first glance.

I'm still getting the runtime error I mentioned before, on this call:
org.bytedeco.javacpp.onnx.OpSchemaRegistry.get_all_schemas()
This call is essential for my application. Works in 1.1.2 and older, pre-rvalue.

The other issue is new with your changes, will comment inline

[EmergentOrder]

Why does this no longer return a vector (TypeConstraintParamVector) ? This type change breaks my code (and no longer reflects schema.h).

[saudet]

Ok, I've fixed that and it seems to work fine now. Thanks for testing!

[EmergentOrder]

Great, both issues are fixed now, thanks!
Now I only get errors due to changes in ONNX internals in the more recent versions, but that's something else entirely...
I approve the license change.
Good to go.