-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct linking of FlyCapture2 on Windows to work with v.2.12.3.2 #613
Conversation
Thanks! Could you also update the archives for CI? |
I don't have them.. went to their download website https://www.ptgrey.com/support/downloads and picked a camera at random, I can only see 2.13.3.31 downloads now, even trying a few different cameras. So looks like they've released a newer version in the meantime, and I can't see any historical downloads section |
The main change in 2.13.3.31 is addition of new video library: new headers, and new libs. Binaries for CI tests still need to be updated.
Was planning on adding a function into the ci script for it to unpack the unmodified SDKs.. not sure best way to get that into this pull request? Open to suggestions.. only can come up with average solutions so far. Meantime will get the code working |
You should be able to push to his fork...? If not, @jpsacha could you give
him permission, if that's ok?
|
@vb216 I added you as a collaborator to my fork [https://github.com/jpsacha/javacpp-presets]. Hopefully this will help to update the PR. |
So I tested over here, https://travis-ci.org/vb216/javacpp-presets/builds/468367814, and it built OK, I've then just pushed that set of changes to the install-travis.sh.. looks like they're picked up on this pull request but some merge conflict - I think thats just an older flycap source file though? |
Thanks! Yes, we'll need to merge manually with master to resolve the conflict.
|
Actually, this one looks good to merge. I'll let the build run, and we'll merge this when it's done. |
Nope, the build is failing on Windows:
https://ci.appveyor.com/project/Bytedeco/javacpp-presets/builds/21138224/job/gthj2pqu11j9957q We'll need to fix this before we can merge. |
No description provided.