Add X265 multilib support for osx and linux-x86* #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X265 supports API selectable internal compression depths of 8,10, or 12 bits. This commit enables building of multilib support for X265 on osx and linux-x86* and enables this feature in ffmpeg.
|
Thanks for the contribution! But it doesn't build: The |
|
Which platform failed?
… On Oct 2, 2018, at 10:04 PM, Samuel Audet ***@***.***> wrote:
Thanks for the contribution! But it doesn't build:
ERROR: libx265 not found
The $INSTALL_PATH needs to be used to have make install them in the right place. BTW, instead of using a patch to modify multilib.sh, we could directly launch these multiple builds from cppbuild.sh. That would make it easier to test and fix.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Linux, Fedora 27, but you'll see it on Travis CI with CentOS 6. |
|
See here: https://travis-ci.org/bytedeco/javacpp-presets/jobs/436238096 |
added 2 commits
October 4, 2018 14:36
Instead of patching x265, we'll execute the commands directly from the cppbuild.sh file.
|
Mac seems to be building fine now, but not Linux: |
|
I’m in the process of rewriting the code to inline it in cppbuild.sh and use INSTALL_PATH and $CMAKE. Should have a new pull request later today.
… On Oct 5, 2018, at 6:23 AM, Samuel Audet ***@***.***> wrote:
Mac seems to be building fine now, but not Linux:
https://travis-ci.org/bytedeco/javacpp-presets/builds/437275915
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
We can skip things like AVX for 32-bit builds. Those binaries are not used for performance anyway. |
|
So the last patch fixed the compile, but now it's erroring in deploy (XCode). As it doesn't appear to be related to this patch, I assume I can ignore. |
|
Yes, it's looking good, thanks! I'd like to do the same with other platforms before merging this though. If you could give it a try, that'd be great. |
|
Looking good! Builds are passing on Windows. Thanks! |
|
Do you think you could work on the builds for Android as well? |
|
I’m trying. I posted a question last week, but it never made it to the list. I can’t get an android build to even complete. I’ve tried following the steps on the wiki, but the build crashes. Is their a complete step-by-step guide to setup a working android environment on Ubuntu 18?
Mark
… On Nov 12, 2018, at 11:26 PM, Samuel Audet ***@***.***> wrote:
Do you think you could work on the builds for Android as well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#619 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHr2R8MG9Q5L36XY--uGtWq0TPDuPXTtks5uukncgaJpZM4XEbg7>.
|
|
This is pretty much it: https://github.com/bytedeco/javacpp-presets/wiki/Build-Environments#android-arm-and-x86 It doesn't work? What message do you get with your crash? |
|
It gets to OpenSSL (I think, we really need a print statement indicating each step of the build), and dies with this:
SIXTY_FOUR_BIT_LONG mode
RC4 uses unsigned char
Configured for android64.
clang70clang70: error: unknown argument: '-mandroid'
: error: unknown argument: '-mandroid'
clang70: warning: -z text: 'linker' input unused [-Wunused-command-line-argument]
… On Nov 13, 2018, at 7:47 AM, Samuel Audet ***@***.***> wrote:
This is pretty much it: https://github.com/bytedeco/javacpp-presets/wiki/Build-Environments#android-arm-and-x86 <https://github.com/bytedeco/javacpp-presets/wiki/Build-Environments#android-arm-and-x86>
It doesn't work? What message do you get with your crash?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#619 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHr2R1IbgIc9uMkAoagGMZJ4LGM0DfGeks5uur95gaJpZM4XEbg7>.
|
|
It gets to OpenSSL (I think, we really need a print statement indicating each step of the build), and dies with this:
SIXTY_FOUR_BIT_LONG mode
RC4 uses unsigned char
Configured for android64.
clang70clang70: error: unknown argument: '-mandroid'
: error: unknown argument: '-mandroid'
clang70: warning: -z text: 'linker' input unused [-Wunused-command-line-argument]
… On Nov 13, 2018, at 7:47 AM, Samuel Audet ***@***.***> wrote:
This is pretty much it: https://github.com/bytedeco/javacpp-presets/wiki/Build-Environments#android-arm-and-x86 <https://github.com/bytedeco/javacpp-presets/wiki/Build-Environments#android-arm-and-x86>
It doesn't work? What message do you get with your crash?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#619 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHr2R1IbgIc9uMkAoagGMZJ4LGM0DfGeks5uur95gaJpZM4XEbg7>.
|
|
Ah, you're trying to build with Clang, that won't work, keep using GCC.
You mean like echo statements in the script? We can add those sure, or just
enabling echo of the commands would be easier I think.
|
|
The issue is that I’m using the cppbuild straight out of the box. So where it’s picking up clang I don’t know. My guess is that it’s an install issue. I’m using r18
Rather than echoing commands, I would have it output something like:
…-------------------
Building zlib
-------------------
… compile output …
-------------------
Building Lame
-------------------
… compile output
At least that way it’s easier to detect which package failed, rather than hunting through the compile output looking for an include or install directory.
On Nov 13, 2018, at 6:19 PM, Samuel Audet ***@***.***> wrote:
Ah, you're trying to build with Clang, that won't work, keep using GCC.
You mean like echo statements in the script? We can add those sure, or just
enabling echo of the commands would be easier I think.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#619 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHr2R7RtiLibzAtv91EMEQ7yOzSR83VAks5uu1OIgaJpZM4XEbg7>.
|
|
The issue is that I’m using the cppbuild straight out of the box. So where it’s picking up clang I don’t know. My guess is that it’s an install issue. I’m using r18.
Rather than echoing commands, I would have it output something like:
…-------------------
Building zlib
-------------------
… compile output …
-------------------
Building Lame
-------------------
… compile output
At least that way it’s easier to detect which package failed, rather than hunting through the compile output looking for an include or install directory.
On Nov 13, 2018, at 6:19 PM, Samuel Audet ***@***.***> wrote:
Ah, you're trying to build with Clang, that won't work, keep using GCC.
You mean like echo statements in the script? We can add those sure, or just
enabling echo of the commands would be easier I think.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#619 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHr2R7RtiLibzAtv91EMEQ7yOzSR83VAks5uu1OIgaJpZM4XEbg7>.
|
|
r18 doesn't have GCC anymore, use r15c as per these instructions:
https://github.com/bytedeco/javacpp-presets/wiki/Build-Environments#android-arm-and-x86
|
|
Everything should work pretty much as is with r15c, for now. We'll need to do something about Clang eventually when other projects like FFmpeg and TensorFlow start supporting it, but it's not really the case for now, unfortunately. |
|
We can add echo commands here and there too that's fine 👍 Thanks |
added 3 commits
November 19, 2018 14:32
Enables multilib on android-x86 and x86_64
Adds multilib capabilkity to the arm variants of android
|
All of the android versions have been committed.
Mark
… On Nov 19, 2018, at 5:21 AM, Samuel Audet ***@***.***> wrote:
We can echo commands here and there too that's fine 👍 Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#619 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHr2R1jdoR52rkCasVYcJRDCA7bGUFFmks5uwoY3gaJpZM4XEbg7>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X265 supports API selectable internal compression depths of 8,10, or 12 bits. This commit enables building of multilib support for X265 on osx and linux-x86* and enables this feature in ffmpeg.