Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build all stable LLVM targets #937

Merged
merged 6 commits into from
Aug 27, 2020

Conversation

junlarsen
Copy link
Member

As discussed in #932 I have enabled LLVM to build all stable targets.

As per bytedeco#932, all stable LLVM targets should be built
@saudet
Copy link
Member

saudet commented Aug 25, 2020

While we're at it, let's also include your code for issue #935? It looks alright.

@saudet
Copy link
Member

saudet commented Aug 26, 2020

Apart from the experimental targets, it looks like the following functions are not actually defined:

   Creating library jniLLVM.lib and object jniLLVM.exp
jniLLVM.obj : error LNK2001: unresolved external symbol "void __cdecl LLVMInitializeXCoreAsmParser(void)" (?LLVMInitializeXCoreAsmParser@@YAXXZ)
jniLLVM.obj : error LNK2001: unresolved external symbol "void __cdecl LLVMInitializeNVPTXAsmParser(void)" (?LLVMInitializeNVPTXAsmParser@@YAXXZ)
jniLLVM.obj : error LNK2001: unresolved external symbol "void __cdecl LLVMInitializeNVPTXDisassembler(void)" (?LLVMInitializeNVPTXDisassembler@@YAXXZ)
jniLLVM.dll : fatal error LNK1120: 3 unresolved externals

Do we just disable them for all targets?

@junlarsen
Copy link
Member Author

Yeah, it seems like those targets don't export those functions for some reason. We could either omit the initialization functions for those targets entirely or we just omit those three functions manually (example gist)

@saudet saudet merged commit 48e7263 into bytedeco:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants