Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded versions for various plugins. #731

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

archenroot
Copy link
Member

@archenroot archenroot commented Dec 26, 2023

I upgraded few plugins and mostly:

 <artifactId>maven-compiler-plugin</artifactId>
149         <version>3.12.1</version>
150         <configuration>
151           <source>1.8</source>
152           <target>1.8</target>

as it was failing on my system to build with 1.7 values:

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=22.04
DISTRIB_CODENAME=jammy
DISTRIB_DESCRIPTION="Ubuntu 22.04.3 LTS"
java 21.0.1 2023-10-17
Java(TM) SE Runtime Environment Oracle GraalVM 21.0.1+12.1 (build 21.0.1+12-jvmci-23.1-b19)
Java HotSpot(TM) 64-Bit Server VM Oracle GraalVM 21.0.1+12.1 (build 21.0.1+12-jvmci-23.1-b19, mixed mode, sharing)

@saudet
Copy link
Member

saudet commented Dec 26, 2023

Could you do the same for https://github.com/bytedeco/javacv/ and https://github.com/bytedeco/javacpp-presets?

@archenroot
Copy link
Member Author

I was looking into javacv repo, but build fails on bytedeco/javacv#2157

I will look into javacpp-presets as well.

@archenroot
Copy link
Member Author

I did the version bump for javacv: bytedeco/javacv#2159. Going to look at javacpp-presets.

@archenroot
Copy link
Member Author

I reverted back the 1.8 to 1.7

changes #revert back 1.8 to 1.7 due to groovy compatibility.
@archenroot archenroot force-pushed the maven-infra-plugins-version-bump branch from c739530 to d2003a0 Compare December 29, 2023 10:48
pom.xml Show resolved Hide resolved
@saudet
Copy link
Member

saudet commented Dec 29, 2023

Please also update the dependencies in src/it/osgi/pom.xml, src/it/osgi/test.bndrun, platform/pom.xml and https://github.com/bytedeco/javacv/blob/master/platform/pom.xml and https://github.com/bytedeco/javacpp-presets/blob/master/platform/pom.xml as well

@saudet saudet merged commit 7a2c518 into bytedeco:master Jan 30, 2024
11 checks passed
@codeinred
Copy link

@archenroot could you provide more information about the issue with groovy compatibility? by this point Java 1.7 is so old that Maven fails to build javacpp:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] Source option 7 is no longer supported. Use 8 or later.
[ERROR] Target option 7 is no longer supported. Use 8 or later.
[INFO] 2 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

I had to manually patch the repo in order to get it to build. Would it be possible to add a flag such that 1.8 was the default version, but 1.7 (or an alternative version) could be used for compatibility?

@saudet
Copy link
Member

saudet commented Apr 5, 2024

We could make it 1.8 when we detect a new version of the JDK that doesn't support 1.7. Please open a pull request!

@HGuillemet
Copy link
Contributor

@archenroot could you provide more information about the issue with groovy compatibility? by this point Java 1.7 is so old that Maven fails to build javacpp

The issue is with JavaCPP Gradle plugin only. See bytedeco/javacpp-presets#1453 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants