-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded versions for various plugins. #731
Upgraded versions for various plugins. #731
Conversation
Could you do the same for https://github.com/bytedeco/javacv/ and https://github.com/bytedeco/javacpp-presets? |
I was looking into javacv repo, but build fails on bytedeco/javacv#2157 I will look into javacpp-presets as well. |
I did the version bump for javacv: bytedeco/javacv#2159. Going to look at javacpp-presets. |
I reverted back the 1.8 to 1.7 |
changes #revert back 1.8 to 1.7 due to groovy compatibility.
c739530
to
d2003a0
Compare
Please also update the dependencies in src/it/osgi/pom.xml, src/it/osgi/test.bndrun, platform/pom.xml and https://github.com/bytedeco/javacv/blob/master/platform/pom.xml and https://github.com/bytedeco/javacpp-presets/blob/master/platform/pom.xml as well |
@archenroot could you provide more information about the issue with groovy compatibility? by this point Java 1.7 is so old that Maven fails to build javacpp:
I had to manually patch the repo in order to get it to build. Would it be possible to add a flag such that 1.8 was the default version, but 1.7 (or an alternative version) could be used for compatibility? |
We could make it 1.8 when we detect a new version of the JDK that doesn't support 1.7. Please open a pull request! |
The issue is with JavaCPP Gradle plugin only. See bytedeco/javacpp-presets#1453 (comment). |
I upgraded few plugins and mostly:
as it was failing on my system to build with 1.7 values: