-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a realtimeStreaming example #1659
Conversation
Thanks! Could you instead put that directly in |
@saudet |
Thanks! If you're having problems building JavaCV or something, let me know and I'll help you out. |
this methond may be a bad design ,As a low-level execution method, it uses the public declare。if we add a param to this , |
Just add another overload like was done for doData. :)
|
another question , i want to write some unit test in /platform/test |
You can ignore that class, it's deprecated.
What do you mean? It's just a normal machine, we can read files normally. |
while all test is ok , in my local machine . I don't know if the file for the build machine exists . like such code in FrameGrabberTest.java
Does it run unit tests when it is built? If not, I will ignore it |
well ,function has been implemented,we can use it by two way
or
|
The file will exist if you create it. I still don't understand what you're worried about. Just try it and if it doesn't work, then we can look at the error message.
Please don't do that, create a new property like isAtFrameRate() and setAtFrameRate() for that please, and then remove the atFrameRate flag from grab(). |
remove "re" check from startUnsafe() add a atFrameRate field
@saudet |
Since this doesn't depend on FFmpeg and we can use it with others like OpenCVFrameGrabber, how about we move this to the parent class FrameGrabber? |
According to the current FrameGrabber design, it is not easy. Different subclasses like OpenCVFrameGrabber/FFmpegFrameGrabber directly implement the grab() method. |
I would just add a grabAtFrameRate() method that calls grab(). What do you say?
|
Do all subclasses need this parameter? if not |
I would do this without a new property, just one new method. |
well , add a method to FrameGrabber and a unit test FrameGrabberRealTimeTest |
Looks good, thanks! But the test is failing... |
because i remove the video path and rtmp server path when i commit ,They only exist in my local |
…), enhance test, and fix nits
#1633
first , add a realtimeStreaming example than can Simulate the "-re" parameter in ffmpeg