Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some overload methods of getXxxMetadata() with charset parameter. #1719

Closed
wants to merge 1 commit into from
Closed

Add some overload methods of getXxxMetadata() with charset parameter. #1719

wants to merge 1 commit into from

Conversation

Konyaco
Copy link
Contributor

@Konyaco Konyaco commented Nov 15, 2021

No description provided.

@saudet
Copy link
Member

saudet commented Nov 18, 2021

How about having a property for that like setCharet()/getCharset()?
If we do it this way, it could also work well for FFmpegFrameRecorder.

@Konyaco
Copy link
Contributor Author

Konyaco commented Nov 18, 2021

How about having a property for that like setCharet()/getCharset()? If we do it this way, it could also work well for FFmpegFrameRecorder.

I think your solution is better. To be honestly, I haven't study other implementations, is it possible to add them to FrameGrabber/FrameRecorder as general methods?

@saudet
Copy link
Member

saudet commented Nov 18, 2021

Yes, that's the idea. We add "charset" fields in the parents, which we can use in the FFmpeg subclasses.

@Konyaco
Copy link
Contributor Author

Konyaco commented Nov 18, 2021

Yes, that's the idea. We add "charset" fields in the parents, which we can use in the FFmpeg subclasses.

I tried, and works fine. Should I make a new PR?

@saudet
Copy link
Member

saudet commented Nov 18, 2021 via email

@Konyaco Konyaco closed this Nov 18, 2021
@Konyaco
Copy link
Contributor Author

Konyaco commented Nov 18, 2021

Great! Please do it in this PR. Thanks

Uhh.. I am sorry that I don't know how to change the branch of PR, so I made a new PR here #1720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants