Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable default color stream if none is enabled in RealSense2FrameGrabber #1750

Merged
merged 5 commits into from
Feb 15, 2022

Conversation

cansik
Copy link
Member

@cansik cansik commented Feb 11, 2022

As mentioned in bytedeco/procamcalib#26 this is a small fix for the RealSense2FrameGrabber to automatically enable the default color stream (in RGB8 format). The same behaviour is also implemented in the RealSenseFrameGrabber.

@cansik
Copy link
Member Author

cansik commented Feb 12, 2022

Added support for stream selection and default stream activation as discussed in bytedeco/procamcalib#25.
Switched to default width, height, framerate properties (bytedeco/procamcalib#26).

By default a color, depth and ir stream is enabled and can be selected by the videoStream attribute (in the same order).

@saudet
Copy link
Member

saudet commented Feb 13, 2022

Looks good! Is there a way to detect when there are more than a single IR sensor and enable the second one too by default? @Faaux was asking about support for that.

@cansik
Copy link
Member Author

cansik commented Feb 13, 2022

Yes, we could check if a stream exists, but if so, I would do it as well for the depth and first IR stream. There are tracking cameras models which only have two color sensors for feature detection and no depth image.

I guess it makes sense to list all the sensors and their video-streams and enable all of them. This approach allows us to support all camera models (current & future).

@cansik
Copy link
Member Author

cansik commented Feb 13, 2022

Implementation to enable all video streams matching the requested width, height and frameRate is done. I am sorting the streams now by the stream_type id, which means the order at the moment is depth < color < ir.

@saudet
Copy link
Member

saudet commented Feb 14, 2022

Sounds good enough. Should we merge? You've tested this and everything works as intended?

@cansik
Copy link
Member Author

cansik commented Feb 14, 2022

I could not test it with all the devices, but with the D455 and D435 it worked as expected. I would say we are ready to merge 🚀

@saudet saudet merged commit 48f58d7 into bytedeco:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants