Adds FFmpegFilterFrame sample for Android #550
Conversation
|
Great! Though since this is 99% identical to the original RecordActivity sample, could you instead simply modify that sample? Thanks! |
|
Ok, will do. I didn't want to edit your original code in case someone didn't want a filter. I'll add a control structure for that. I'll send a pull request in the morning. |
|
Awesome! You can also simply update the branch of this pull request |
pachev
force-pushed
the
sample/rotatevideo
branch
2 times, most recently
from
00db458
to
50981ef
Compare
pachev
force-pushed
the
sample/rotatevideo
branch
from
50981ef
to
af30f31
Compare
|
Ok, I added it to the original RecordActivity sample. Have a good day 😄 ! |
|
Looks great! Although it would probably be more efficient to create and start the FFmpegFrameFilter only once, alongside FFmpegFrameRecorder, or is this not working because of some bug in JavaCV? |
|
Yes, you're right. It's better to start it once when the recorder starts. The code has been updated. Good catch! I've also tested it on a Nexus 5x but with an RTMP feed instead of saving it to the device. |
|
Looks good! Thanks a lot |
No description provided.