Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFmpegFrameGrabber's timeout for RTSP #711 #712

Merged
merged 7 commits into from
Jun 15, 2017

Conversation

d-a-gerashenko
Copy link
Contributor

Two methods to test "connection is lost" situations. In addition to #711 issue.

@saudet
Copy link
Member

saudet commented Jun 7, 2017

Thanks for the contribution! Since this works only for RTSP, maybe we could name the sample RtspStreamingTimeout.java, what do you think?

@d-a-gerashenko
Copy link
Contributor Author

Ok. Should I do it or you will rename it?

@saudet
Copy link
Member

saudet commented Jun 7, 2017 via email

@saudet
Copy link
Member

saudet commented Jun 11, 2017

It looks like we can set the "timeout" for the FTP, HTTP, RTMP, SMB, SSH, TCP, UDP, and UNIX protocols as well, in addition to a generic "rw_timeout": http://ffmpeg.org/ffmpeg-all.html#Protocols

Would you mind adding this in commented lines of (even if untested) code?
And then we can name the file, maybe, "FFmpegStreamingTimeout.java"? :)

@d-a-gerashenko
Copy link
Contributor Author

Interesting. Yes, sure) I'll test it. If it works there is no need in "stimeout".

@d-a-gerashenko
Copy link
Contributor Author

d-a-gerashenko commented Jun 13, 2017

Nope. "rw_timeout" isn't working. Actually it's working when grabber is already connected and has lost connection. But it's not working when network interface was disabled before connection attempt.

@saudet
Copy link
Member

saudet commented Jun 13, 2017 via email

@d-a-gerashenko
Copy link
Contributor Author

continuous-integration/travis-ci/pr — The Travis CI build failed

Is it normal?

I didn't change the file's name because the option doesn't work the way we expected. Right?

@saudet
Copy link
Member

saudet commented Jun 14, 2017 via email

@saudet
Copy link
Member

saudet commented Jun 14, 2017 via email

@d-a-gerashenko
Copy link
Contributor Author

Ok. I can rename it to FFmpegStreamingTimeout but I will add comment that it was tested with RTSP only.

@saudet
Copy link
Member

saudet commented Jun 14, 2017 via email

@d-a-gerashenko
Copy link
Contributor Author

I think it's done.

@saudet
Copy link
Member

saudet commented Jun 15, 2017

Thanks! Had to fix the filename though

@saudet saudet merged commit 049dc98 into bytedeco:master Jun 15, 2017
@d-a-gerashenko
Copy link
Contributor Author

Oops. Sorry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants