Support change of resolution during grabbing. Usecase: UDP streaming … #769
Conversation
…with changing sources / qualities. Test included. Signed-off-by: Michael Fritscher <michael.fritscher@telematik-zentrum.de>
Signed-off-by: Michael Fritscher <michael.fritscher@telematik-zentrum.de>
Signed-off-by: Michael Fritscher <michael.fritscher@telematik-zentrum.de>
…with changing sources / qualities. Test included. Signed-off-by: Michael Fritscher <michael.fritscher@telematik-zentrum.de>
…with changing sources / qualities. Test included. Signed-off-by: Michael Fritscher <michael.fritscher@telematik-zentrum.de>
…avacv into dynamic_resolution # Conflicts: # platform/src/test/java/org/bytedeco/javacv/FrameGrabberTestChangingResolution.java
|
Looks good, but for some reason, your tests are not getting run by Maven. Could you check out why this is the case? The same is happening with pull #770. Thanks! |
|
I think this is because I didn't registered them. I'll need to search the relevant file first ;-) |
|
No, JUnit should pick them up automatically...
|
|
Looks like we have an answer here: |
|
Aaaahhhhh - naming conventions :-) Thanks for this hint! I can put the test into the already existing FrameGrabberTest file, no problem. I only thought that you prefer to put it into an extra file ;-) |
|
Yes, FrameGrabberTest is fine, as long as they pass :) |
# Conflicts: # src/main/java/org/bytedeco/javacv/FFmpegFrameGrabber.java # src/main/java/org/bytedeco/javacv/FFmpegFrameRecorder.java
…with changing sources / qualities. Test included. Signed-off-by: Michael Fritscher <michael.fritscher@telematik-zentrum.de>
…avacv into dynamic_resolution
Signed-off-by: Michael Fritscher <michael.fritscher@telematik-zentrum.de>
|
Ok, seems to work now :-) I had to leave the test in an extra file - I have the feeling that else FrameGrabberTest would be overhelmed by this test (3 helper functions, 2 threads, 3 global variables) |
|
Sure, that's fine, thanks! We just need to remove FFmpegFrameLock.java now :) |
…with changing sources / qualities.
Test included.
Signed-off-by: Michael Fritscher michael.fritscher@telematik-zentrum.de