Returns possibility to use old seeking code (prior to v. 1.4.1) #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rounding estimated frameNumber.
setting frameGrabbed to false after grabbing; update of videoStream and audioStream variables after starting grabber; add helper API functions hasVideo(), hasAudio() and printFormatInfo(int);
Add test seeking in audio only and video only files;
(VIDEO, AUDIO, ANY)
add getLengthInVideoFrames() alias of getLengthInFrames(); cleanup;
|
Thanks for the patch and sorry for the delay! I've reverted a couple more changes because the following line actually restricts the loop to a single call to if (frame.image != null || frame.samples != null) break; // stop flushing if a frame containing data was grabbedIt sometimes does get a bit weird when there are both audio and video frames though, but I think we should focus on the new code and leave the old one alone. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a need sometimes to allow people to use old style method of setTimestamp() which was used in JavaCV prior to 1.4.1. The old method does not check the data type contained in the frame and thus can be faster than the new one.