-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source paragraph does not honor syntax highlighter #704
Comments
Agree with you, there are probably areas where the syntax highlighting is not supported yet 😬 From the the Chroma project page:
So it's not totally a "lie" ;) And it provides compatibility with Asciidoctor. |
Yeah chroma seems nice, and CSS compatible with pygments. But it's not pygments. We probably should offer an alias of chroma -- if only to give credit where it's due to the chroma author(s). (I'd argue that chroma should be the preferred name, pygments accepted as an alias, actually.) |
yes, that's a fair point 👍 |
This fixes three separate issues (it was natural to fix them all at the same time). Fixes bytesparadise#719 Should not panic on unrecognized source language Fixes bytesparadise#706 Support "Chroma" as a syntax highlighter choice Fixes bytesparadise#704 Source paragraph does not honor syntax highlighter
We emit the highlighter ("pygments", which is a kind of lie) on the class for listingblocks that come via a source-block, but not those coming from a source-paragraph.
This is almost certainly an oversight. (And also possibly related to #703 -- i.e. fixing #703 will probably resolve this, provided that we resolve in favor of the syntax highlighter.)
The text was updated successfully, but these errors were encountered: